Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed links incorrectly URL-encoded #10151

Closed
cyberduck opened this issue Nov 22, 2017 · 3 comments
Closed

Signed links incorrectly URL-encoded #10151

cyberduck opened this issue Nov 22, 2017 · 3 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Nov 22, 2017

3d620ce created the issue

Jussi Sallinen reports that generating signed URLs for objects with spaces in the path results in the following error when visiting the URL:

{
"code": "InvalidSignature",
"message": "The signature we calculated does not match the one you sent"
}

I can confirm this is failing in Cyberduck as well (any URL encoding of the object's path causes the issue, including parent directories). Some initial investigation seems to point to the issue being in java-manta, not the Cyberduck codebase. Will update this ticket with a link to the java-manta ticket once that issue is resolved.

(note: this is marked "core" since there is no manta/triton component in the bug tracker)

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 22, 2017

@dkocher commented

I also had a look and it looks like the API should take care of URL encoding using MantaUtils#formatPath and we should pass the unencoded path to getAsSignedURI as what is currently the case.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 27, 2017

3d620ce commented

joyent/java-manta#380 has been merged, I'll close this ticket once 3.2.1 is released.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 3, 2017

@dkocher commented

In bdbd96c.

@cyberduck cyberduck closed this Dec 3, 2017
@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant