Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUFeedURL key in Info.plist for macOS builds #11219

Closed
cyberduck opened this issue Oct 28, 2020 · 6 comments
Closed

Add SUFeedURL key in Info.plist for macOS builds #11219

cyberduck opened this issue Oct 28, 2020 · 6 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Oct 28, 2020

340541d created the issue

Adding this key in the root of the Info.plist file allows for apps like Latest (https://github.com/mangerlahn/Latest) to detect and install updates.

I have verified that this works by adding the key manually with Xcode and the URL set to https://version.cyberduck.io/changelog.rss . Attached is a screenshot of Latest detecting a newer version of Cyberduck with just this change. Installing the update worked properly too.

I would open a PR to add this but I was unsure if this required any further tweaking as there seem to be multiple feeds looking through the source code and the interface.


Attachments

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2020

@dkocher commented

Alternatively there is a Homebrew Cask which is maintained.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2020

@dkocher commented

We allow to switch between update feeds and thus have no need for a default. However we do explicitly set the update feed from this preference in code and thus it should not do any harm to have a default again in Info.plist.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2020

@dkocher commented

A change request would need to set this dynamically from the default update feed set from our CI environment for the different builds and set it accordingly like CFBundleVersion and CFBundleShortVersionString. Refer to build.settings in build.xml.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2020

340541d commented

Thanks for your quick reply. The homebrew cask is a good option indeed, however homebrew will not keep it up to date because auto_updates is set.

It looks like the sparkle feed is already set in the Xcode build options which get included in the other build targets. This looks like it should make it trivial to include this variable in the info.plist considering how the others are integrated. I will look into opening a PR on GitHub for this tomorrow if I get the chance.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 4, 2020

@dkocher commented

In d14ec56.

Loading

@cyberduck cyberduck closed this Dec 4, 2020
@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 30, 2020

@dkocher commented

Milestone renamed

Loading

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant