Skip to content

Support building an app-image with jpackage for Linux CLI #11762

@cyberduck

Description

@cyberduck

bea33a4 created the issue

We would like to package the CLI component of Cyberduck for Linux in Homebrew (which supports Linux in addition to macOS). Currently the Maven build.xml for the CLI component on Linux only builds RPM or DEB packages, which we cannot use. However, the app-image build type for jpackage generates the binary and libraries in a regular directory that we can copy into our packages.

Adding app-image as an antcall to the build.xml is not quite sufficient for the build to succeed. The jpackage target in the build.xml file has 3 arguments (license-file, linux-deb-maintainer, and linux-rpm-license-type) which are not valid when building an app-image, and cause the build to fail. I circumvented this by simply deleting those lines from the build.xml (Homebrew/homebrew-core#83110), but I'd like to be able to properly add support for app-image as a build type.

I think the best way to do this is by making a "jpackage-app-image" target which doesn't include the invalid arguments, and use that target with the antcall for building an app-image, but I'd like to get some idea of whether this is how this project would like to implement this. I am happy to make a pull request on GitHub once the solution has been agreed upon.

Metadata

Metadata

Assignees

Labels

cliCommand Line Interface

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions