Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building an app-image with jpackage for Linux CLI #11762

Closed
cyberduck opened this issue Aug 12, 2021 · 4 comments
Closed

Support building an app-image with jpackage for Linux CLI #11762

cyberduck opened this issue Aug 12, 2021 · 4 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Aug 12, 2021

bea33a4 created the issue

We would like to package the CLI component of Cyberduck for Linux in Homebrew (which supports Linux in addition to macOS). Currently the Maven build.xml for the CLI component on Linux only builds RPM or DEB packages, which we cannot use. However, the app-image build type for jpackage generates the binary and libraries in a regular directory that we can copy into our packages.

Adding app-image as an antcall to the build.xml is not quite sufficient for the build to succeed. The jpackage target in the build.xml file has 3 arguments (license-file, linux-deb-maintainer, and linux-rpm-license-type) which are not valid when building an app-image, and cause the build to fail. I circumvented this by simply deleting those lines from the build.xml (Homebrew/homebrew-core#83110), but I'd like to be able to properly add support for app-image as a build type.

I think the best way to do this is by making a "jpackage-app-image" target which doesn't include the invalid arguments, and use that target with the antcall for building an app-image, but I'd like to get some idea of whether this is how this project would like to implement this. I am happy to make a pull request on GitHub once the solution has been agreed upon.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Aug 13, 2021

@dkocher commented

http://ant.apache.org/manual/ifunless.html
It might be possible to use the If And Unless attributes instead of the new target.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Aug 13, 2021

@dkocher commented

A pull request would be very welcome.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Sep 12, 2021

@dkocher commented

It would be great if you can test this branch with changeset (18b2297).

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Sep 13, 2021

@dkocher commented

In 18b2297.

Loading

@cyberduck cyberduck closed this Sep 13, 2021
@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants