Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leopard: Saving file in external editor doesn't cause upload #1244

Closed
cyberduck opened this issue Sep 10, 2007 · 15 comments
Closed

Leopard: Saving file in external editor doesn't cause upload #1244

cyberduck opened this issue Sep 10, 2007 · 15 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Sep 10, 2007

c63a6c4 created the issue

Using Leopard (9A527) and CyberDuck 2.8b1 (3212)/3212, and SubEthaEdit as an external editor, I notice that when editing a file and saving back, the file is not re-uploaded.

This is logged to the console:

9/10/07 12:58:29 PM Cyberduck[1178] handleModifiedFileEvent: Got ODB editor event for unknown file. 
9/10/07 12:58:30 PM Cyberduck[1178] handleClosedFileEvent: Got ODB editor event for unknown file. 


@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 27, 2007

24a075c commented

Just wanted to confirm that this is still occurring in final release. Tested using CyberDuck 2.8 385ff8a and TextMate.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 27, 2007

a735a1d commented

I confirm : same problem, with any text editor.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 27, 2007

8841594 commented

I've the same problem with leopard final (golden master) with bbedit.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2007

GREENSKiN commented

Confirmed under Leopard retail, with CyberDuck 2.8 (3257) and TextMate 1.5.7 (1436).

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2007

GREENSKiN commented

I inserted some debug code in the source... I think Leopard reports symlinks in a different way than Tiger did:

10/28/07 9:52:23 PM Cyberduck[13529] handleModifiedFileEvent: Got ODB editor event for unknown file (/private/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php).
10/28/07 9:52:23 PM Cyberduck[13529] Dictionary contains... {
"/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php" = {
ODBEditorFileName = "/var/folders/wO/wOFigXmSH9ykExpUW4b+qU+++TI/-Tmp-/var/www/test-3.php";
ODBEditorIsEditingString = 0;
ODBEditorNonRetainedClient = <10291000>;
};
}

As you can see TextMate reports /private/var/... for the filename, whereas Cyberduck has stored /var/... in its dictionary object.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2007

GREENSKiN commented

Patch!

\214c214
< 			[_filesBeingEdited setObject: dictionary forKey: [fileName stringByResolvingSymlinksInPath]];
---
> 			[_filesBeingEdited setObject: dictionary forKey: fileName];
233c233
< 	dictionary = [_filesBeingEdited objectForKey: [fileName stringByResolvingSymlinksInPath]];
---
> 	dictionary = [_filesBeingEdited objectForKey: fileName];
254c254
< 	dictionary = [_filesBeingEdited objectForKey: [fileName stringByResolvingSymlinksInPath]];
---
> 	dictionary = [_filesBeingEdited objectForKey: fileName];

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 28, 2007

a735a1d commented

how do you patch the app ?
would you put somewhere the app patched ?

jean

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 29, 2007

24a075c commented

The patch from greenskin works great, though he forgot to mention the file to be patched:

cyberduck/source/ch/cyberduck/ui/cocoa/odb/ODBEditor.m

I've applied his patch to the latest svn version and compiled it as a temporary fix for anybody interested. Not sure if it's compatible with 10.4 but it works great in 10.5.

http://www.createarevolution.com/downloads/cyberduck-8c9b7b1e7f877876b861bde3e97544ba94181511-10.5.zip

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 29, 2007

@dkocher commented

Thanks for the patch! I will test under 10.3.9-10.5 and then apply. You will find the latest build at http://update.cyberduck.ch/nightly/ then.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 30, 2007

@dkocher commented

I have added a cyberduck-dev mailing list to make it easier to discuss code. See #1202.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 30, 2007

@dkocher commented

In dfcb07b.

@cyberduck cyberduck closed this Oct 30, 2007
@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 30, 2007

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 1, 2007

chuckienorton commented

I just downloaded the new build & still cannot even select an editor. (using leopard). Am I missing something?? Thanks, -Chuck

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 13, 2007

123af01 commented

It would be nice if that build were available by update in the client I didn't like having to search around in trac to find it. glas it's here though

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 13, 2007

@dkocher commented

An official release is due soon but there are one or two other issues I want to have resolved first. Thanks for your patience.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants