Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect disabled ACLs for S3 #13386

Closed
ylangisc opened this issue May 13, 2022 · 1 comment · Fixed by #13402 or #13481
Closed

Detect disabled ACLs for S3 #13386

ylangisc opened this issue May 13, 2022 · 1 comment · Fixed by #13402 or #13481
Labels
enhancement s3
Milestone

Comments

@ylangisc
Copy link
Contributor

@ylangisc ylangisc commented May 13, 2022

Amazon S3 Object Ownership can now disable access control lists to simplify access management for data in S3

Cyberduck should be able to detect buckets with ACLs disabled to avoid sending any default ACL which would result in the following error otherwise:

The bucket does not allow ACLs.

It should not be necessary to set the default ACL to None if there is no IAM policy preventing Cyberduck from reading the bucket ownership configuration.

Also refer to:

@ylangisc ylangisc added the s3 label May 13, 2022
@dkocher dkocher added this to the 8.4.0 milestone May 19, 2022
dkocher added a commit that referenced this issue May 20, 2022
Return empty ACL in case of disabled ACLs.
@dkocher dkocher reopened this Jun 16, 2022
dkocher added a commit that referenced this issue Jun 16, 2022
@dkocher dkocher linked a pull request Jun 16, 2022 that will close this issue
dkocher added a commit that referenced this issue Jun 17, 2022
@dkocher
Copy link
Contributor

@dkocher dkocher commented Jun 22, 2022

Addendum in #13496.

dkocher added a commit that referenced this issue Jun 23, 2022
Do not attempt to modify ACL when copying objects ownership controls for bucket has BucketOwnerEnforced policy set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement s3
Projects
None yet
2 participants