Bonjour installation is not optional, can't be removed via normal means

[savchenko]

Describe the bug
Bonjour installation isn't optional anymore, it can't be removed manually from "Apps & Features" or a "classic" Control panel.

To Reproduce
Steps to reproduce the behavior:

1. Download Cyberduck-Installer-8.3.3.37544.exe
2. Try to install without Bonjour
3. Realise it's not optional, try to uninstall the Bonjour without wiping the Cyberduck

Expected behavior
Make Bonjour optional as per ee952d1 and allow it to be uninstalled as per #10850

Screenshots

Cyberduck installed

Installer options

Desktop (please complete the following information):

• OS: Windows 10 21H2
• Version: 10.0.19044 Build 19044

Log Files
N/A

Additional context
See the linked issue & commit.

[leifcr]

This was originally fixed in #5563 back in 2010, but has sneak back it seems.

Workaround to stop the service:

1. Run services.msc
2. Right click Bonjour service, click properties
3. Set startup to manual or deactivated
4. Stop the service (Right click + stop)

At least that disables for now.

[AliveDevil]

After merge Bonjour is removed automatically through auto-update. Installing Bonjour requires either running the installer again with the Bonjour checkbox selected (default), or installing Bonjour manually.

[AliveDevil]

Reviewed this, new behavior will be:

• Bonjour is opt-out (Options -> Bonjour checkbox)
• On Update, the installer checks for an existing Bonjour installation, and keeps the installation alive
• If Bonjour is removed after Cyberduck got installed, any future update won't install Bonjour again
• After merge the update should make Bonjour visible in Programs & Features
• For automated installations the property Cyberduck-Installer.exe InstallBonjour=0 can be used.