Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files downloaded overwritten if same name in outline hierarchy #1400

Closed
cyberduck opened this issue Dec 7, 2007 · 6 comments
Closed

Files downloaded overwritten if same name in outline hierarchy #1400

cyberduck opened this issue Dec 7, 2007 · 6 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Dec 7, 2007

5c89ec5 created the issue

When I select a folder on the server and a file inside the folder and then start a download the file is downloaded twice.

I am connected to an ftp server and have navigated to folder1 and the following is showing in the window:



/home/me/folder1

file1.zip

folder2

file2.zip



file1.zip is inside folder1

folder2 is inside folder1

file2.zip is inside folder2

I select all three entries and drag them to an empty finder window, initiating a download.
The result in the finder window after the download completes is this:



file1.zip

file2.zip

folder2

file2.zip

file2.zip has been downloaded two times!

I understand why this happens but I don't think it should happen. file2.zip is downloaded once because it is selected and a second time because it is inside folder2, which was also selected.

What I expect to happen is that the files and folders downloaded end up to be the same on my local machine as they were on the server.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 7, 2007

@dkocher commented

This has been reported before in #1227.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 7, 2007

5c89ec5 commented

Let me recommend that the download behavior in outline format be modeled after the way that the Finder does a similar copy operation in outline format.

If a folder is selected and downloaded then all its contents are always downloaded and placed into a downloaded folder of the same name.

If a folder isn't selected but a file inside a folder is selected then that file is downloaded and placed at the top level in the download location.

If multiple files are selected in different folders but no folders are selected then all are downloaded to the top level in the download location.

#1227 discusses a different issue.

The name change to this ticket also suggests that you are discussing a third issue (overwriting of downloaded files when files of the same name are downloaded.)

The bug I am reporting is that a file will be downloaded two times when it shouldn't be. If a folder is selected and a file inside that folder is selected when a download is initiated then the folder and all its contents will be downloaded, as expected, but also the selected file will be downloaded and placed at the top level of the download location. The selected file should not be downloaded two times. It should only be downloaded as part of the contents of the downloaded folder. It should not be downloaded a second time and placed at the top level.

The Finder does all of this in a consistent manner and CyberDuck should do things the same way.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 7, 2007

@dkocher commented

The issue you describe that files are downloaded twice only occurs when dragging the files to the Finder but not when just choosing 'Download' from the Menu. I just observed this. We'll try to fix both issues.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 7, 2007

@dkocher commented

Issue as it was meant when reported fixed as of b926601. Issue #1227 still open.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 8, 2007

@dkocher commented

Fixed in 46aa2b7.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jun 12, 2010

moskovskie shalavy commented

Aloha! http://trac.stromnet.se/nis/ticket/79 shluhi moskvy hier.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants