Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files not removed in vault when deleting folder #14101

Closed
stephankn opened this issue Jan 18, 2023 · 3 comments · Fixed by #16505
Closed

Files not removed in vault when deleting folder #14101

stephankn opened this issue Jan 18, 2023 · 3 comments · Fixed by #16505
Assignees
Labels
1&1 box Box Protocol Implementation cryptomator Cryptomator Vault deepbox Protocol to access document sharing platform DeepBox dracoon DRACOON Protocol Implementation dropbox Dropbox Protocol Implementation files.com Files.com Protocol Implementation googledrive Google Drive Protocol Implementation irods IRODS Protocol Implementation onedrive OneDrive Protocol Implementation smb Server Message Block (SMB) spectralogic Spectralogic Protocol Implementation storegate webdav WebDAV Protocol Implementation
Milestone

Comments

@stephankn
Copy link

Describe the bug
Deleting encrypted folder only removes directory entries, but leaves the encrypted files in cloud storage

To Reproduce

  1. Connect to Onedrive Personal folder
  2. Create New encrypted vault
  3. upload directly tree into vault (eg one root folder containing several files and subdirectories)
  4. enter vault and delete the root folder of the data just uploaded

Expected behavior
Expected is that cyberduck deletes the encrypted files on cloud drive representing the content of the vault. Instead it only deletes a few files likely be metadata files which makes the folder to disappear in cyberduck, but files still reside on cloud.

Further info

vault created and files uploaded

rclone lsl onedriveStephan:cd-test/crypt2/
      327 2023-01-18 19:56:35.510000000 masterkey.cryptomator
      287 2023-01-18 19:56:41.386000000 vault.cryptomator
      250 2023-01-18 19:57:45.580000000 d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF/YAeGOXcfRDh9G93g2y0lHfdApbpCH6m0TQ==.c9r
     1370 2023-01-18 19:57:40.773000000 d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF/ZCBCGJXKHGJQrdeKvhchxhSkuDFV1l8=.c9r
     3873 2023-01-18 19:57:40.816000000 d/YK/XMZJ3ZFJ5LUYNA3R5JIHE4YADU5FLC/64Qtw4KgrV7PRdMX7BIsVzS2jvbdyCxy6uzlLp87y5G-9Lw=.c9r
      242 2023-01-18 19:57:40.846000000 d/YK/XMZJ3ZFJ5LUYNA3R5JIHE4YADU5FLC/DdIhdWJ0buE7Opg3XZGXPVZapL4nSRvcVuxC.c9r
      840 2023-01-18 19:57:40.920000000 d/YK/XMZJ3ZFJ5LUYNA3R5JIHE4YADU5FLC/awUBj8La9Zmcd-23MZZGz2gk7dUgCFK2MA==.c9r
   203144 2023-01-18 19:57:40.926000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/2MKIehBpLiWAO_HYtLMwOv6GB55rS81hVtOnIWs5prbeFA==.c9r
     1407 2023-01-18 19:57:40.850000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/Awy5ng1aNqykzUyS7Ap6vmGyzlQjA5xS2Q==.c9r
      284 2023-01-18 19:57:40.680000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/EtKtZ2tREBNxbPtS4t4EUHEKXH15.c9r
      675 2023-01-18 19:57:40.806000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/RTgx3eBudbztZ5v-jUkuGzEq_4mZ1mhCiqg=.c9r
     1046 2023-01-18 19:57:40.776000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/arBJG3308JrY5PN0Nj7_O-9tm4naiHc1AvKhzK2bRg==.c9r
       36 2023-01-18 19:57:39.730000000 d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF/1t85gGYzHNqTHYQ-WRQC-qhtDm_Q.c9r/dir.c9r
       36 2023-01-18 19:57:38.660000000 d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF/W_GLuKCQ3anivPiMyMxBae6L83nk.c9r/dir.c9r
       36 2023-01-18 19:57:37.656000000 d/NN/JQ3MWISBWTIEJWCL3Y5M4BT5MHAOAB/TceW2qtJNMtlzjmmVeijdAoc_FpC32X104Ll6RwR5K90XA==.c9r/dir.c9r

deleting top-level folder in cyberduck only deletes dir,c9r files and leaves other files behind:

rclone lsl onedriveStephan:cd-test/crypt2/
      327 2023-01-18 19:56:35.510000000 masterkey.cryptomator
      287 2023-01-18 19:56:41.386000000 vault.cryptomator
     3873 2023-01-18 19:57:40.816000000 d/YK/XMZJ3ZFJ5LUYNA3R5JIHE4YADU5FLC/64Qtw4KgrV7PRdMX7BIsVzS2jvbdyCxy6uzlLp87y5G-9Lw=.c9r
      242 2023-01-18 19:57:40.846000000 d/YK/XMZJ3ZFJ5LUYNA3R5JIHE4YADU5FLC/DdIhdWJ0buE7Opg3XZGXPVZapL4nSRvcVuxC.c9r
      840 2023-01-18 19:57:40.920000000 d/YK/XMZJ3ZFJ5LUYNA3R5JIHE4YADU5FLC/awUBj8La9Zmcd-23MZZGz2gk7dUgCFK2MA==.c9r
   203144 2023-01-18 19:57:40.926000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/2MKIehBpLiWAO_HYtLMwOv6GB55rS81hVtOnIWs5prbeFA==.c9r
     1407 2023-01-18 19:57:40.850000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/Awy5ng1aNqykzUyS7Ap6vmGyzlQjA5xS2Q==.c9r
      284 2023-01-18 19:57:40.680000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/EtKtZ2tREBNxbPtS4t4EUHEKXH15.c9r
      675 2023-01-18 19:57:40.806000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/RTgx3eBudbztZ5v-jUkuGzEq_4mZ1mhCiqg=.c9r
     1046 2023-01-18 19:57:40.776000000 d/3V/7G7PIWCH4IW5YO2TA7ORKOBMWDI4GM/arBJG3308JrY5PN0Nj7_O-9tm4naiHc1AvKhzK2bRg==.c9r

Desktop & Versions:

  • OS: Microsoft Windows [Version 10.0.19044.2486]
  • Cyberduck Version: 8.5.5 (39108)

Log Files
Log file is attached. I redacted some entries to not leak access tokens.
cyberduck.log

Additional context
This is the only line I see with the class ERROR. If refers to one of the directory meta-files cyberduck deleted.

2023-01-18 19:58:16,512 [background-16] DEBUG ch.cyberduck.core.cryptomator.impl.CryptoDirectoryV6Provider - Use directory ID '20891ded-29f7-462a-a495-6827b88b364e' for folder Path{path='/My Files/cd-test/crypt2/zabbix-userscripts', type=[directory, decrypted]}
2023-01-18 19:58:16,512 [background-16] DEBUG ch.cyberduck.core.cryptomator.features.CryptoDeleteV7Feature - Deleting directory id backup file Path{path='/My Files/cd-test/crypt2/d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF/dirid.c9r', type=[file]}

2023-01-18 19:58:17,292 [background-16] ERROR ch.cyberduck.core.cryptomator.features.CryptoDeleteV7Feature - Failure BackgroundException{class=class ch.cyberduck.core.exception.NotfoundException, file=null, message='File not found', detail='/My Files/cd-test/crypt2/d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF/dirid.c9r', cause='null'} deleting directory id backup file Path{path='/My Files/cd-test/crypt2/d/6W/46VERJU4NVVLW26ZX7IQ2S5B7NT2MF', type=[directory, encrypted]}

2023-01-18 19:58:17,293 [background-16] INFO  ch.cyberduck.transcript.request - DELETE /v1.0/drives/<redacted1>/items/<redacted1>!51974 HTTP/1.1

@dkocher dkocher added cryptomator Cryptomator Vault onedrive OneDrive Protocol Implementation labels Jan 19, 2023
@dkocher dkocher changed the title Deleting files in cryptomator vault leaves the files back in onedrive Files not removed in vault when deleting folder Jan 19, 2023
@CodeShakingSheep
Copy link

I'm running into the same issue with a WebDav connection and a vault inside it. It took me hours to understand why my vault was still so big in size after I had deleted a folder with 15GB. The tricky thing is when unlocking the vault with Cryptomator the folder doesn't even show anymore but it's still present in an encrypted state. A fix would be very much appreciated from my side.

@A37stKpDodi4BEr65TXb
Copy link

I just ran into the same issue with an encrypted vault saved on Google Drive

OS: Win 10 Home 22H2 19045.4651
Cyberduck Version 9.0.0 41777

@dkocher
Copy link
Contributor

dkocher commented Nov 6, 2024

I cannot seem to reproduce. Tested with deleting a folder containing three files in a Cryptomator Vault on Microsoft OneDrive.

I can confirm the bug which applies to protocols that support recursively deleting folders. In this case we fail to delete all containing files as the encrypted folder structure is not following the same hierarchy as the decrypted view.

@dkocher dkocher added webdav WebDAV Protocol Implementation googledrive Google Drive Protocol Implementation dropbox Dropbox Protocol Implementation irods IRODS Protocol Implementation spectralogic Spectralogic Protocol Implementation dracoon DRACOON Protocol Implementation box Box Protocol Implementation files.com Files.com Protocol Implementation smb Server Message Block (SMB) storegate deepbox Protocol to access document sharing platform DeepBox 1&1 labels Nov 7, 2024
@dkocher dkocher added this to the 9.1 milestone Nov 7, 2024
@dkocher dkocher self-assigned this Nov 7, 2024
dkocher added a commit that referenced this issue Nov 7, 2024
@dkocher dkocher linked a pull request Nov 7, 2024 that will close this issue
dkocher added a commit that referenced this issue Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1&1 box Box Protocol Implementation cryptomator Cryptomator Vault deepbox Protocol to access document sharing platform DeepBox dracoon DRACOON Protocol Implementation dropbox Dropbox Protocol Implementation files.com Files.com Protocol Implementation googledrive Google Drive Protocol Implementation irods IRODS Protocol Implementation onedrive OneDrive Protocol Implementation smb Server Message Block (SMB) spectralogic Spectralogic Protocol Implementation storegate webdav WebDAV Protocol Implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants