Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ca-west-1 (Calgary) to the S3 defaults #16215

Closed
Joshuah143 opened this issue Aug 8, 2024 · 2 comments · Fixed by #16227
Closed

Add support for ca-west-1 (Calgary) to the S3 defaults #16215

Joshuah143 opened this issue Aug 8, 2024 · 2 comments · Fixed by #16227
Assignees
Labels
enhancement s3 AWS S3 Protocol Implementation
Milestone

Comments

@Joshuah143
Copy link
Contributor

Joshuah143 commented Aug 8, 2024

Describe the bug
Add support for ca-west-1 (Calgary) to the default bucket location.

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings
  2. Click S3
  3. See the options in the default bucket location

Screenshots

Current default S3 locations:
Screenshot 2024-08-07 at 10 01 35 PM

Desktop (please complete the following information):

  • OS: MacOS 14.6
  • Version 4.16.2 (Mountain Duck)
  • Version 9.0.1 (Cyber Duck)

Additional context
Amazon recently introduced a new region.

Can I have a go at fixing? Should be super simple.

@Joshuah143 Joshuah143 changed the title Add support for ca-west-1 (Calgary) to the default bucket location Add support for ca-west-1 (Calgary) to the S3 defaults Aug 8, 2024
@Joshuah143
Copy link
Contributor Author

Should be simple addition above this line:

<string>ca-central-1</string>

@tatze96
Copy link

tatze96 commented Aug 8, 2024

Thanks for letting us know about the new S3 region.

Can I have a go at fixing? Should be super simple.

Contributions are always welcome. You can open a pull request with your changes.

Should be simple addition above this line:

<string>ca-central-1</string>

Correct, but the addition should be below the line because of the alphabetical ordering.

@tatze96 tatze96 added enhancement s3 AWS S3 Protocol Implementation labels Aug 8, 2024
@dkocher dkocher added this to the 9.1 milestone Aug 9, 2024
@dkocher dkocher self-assigned this Aug 13, 2024
dkocher added a commit that referenced this issue Aug 13, 2024
dkocher added a commit that referenced this issue Aug 13, 2024
@dkocher dkocher linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement s3 AWS S3 Protocol Implementation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants