Skip to content

Downloading a Google Drive folder also downloads files in the trash #16927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ks-sst opened this issue Mar 8, 2025 · 1 comment · Fixed by #16930
Closed

Downloading a Google Drive folder also downloads files in the trash #16927

ks-sst opened this issue Mar 8, 2025 · 1 comment · Fixed by #16930
Assignees
@dkocher
Labels
box Box Protocol Implementation googledrive Google Drive Protocol Implementation
Milestone
9.1.4

Comments

@ks-sst
Copy link

ks-sst commented Mar 8, 2025

When you download a Google Drive folder, any files in the trash in that folder will also be downloaded.

Confirmed with Cyberduck-9.1.2.42722 and Cyberduck-9.1.3.42945

It works fine with Cyberduck-9.0.2.42108

macOS 14.7.4
@dkocher dkocher self-assigned this Mar 9, 2025
@dkocher dkocher added the googledrive Google Drive Protocol Implementation label Mar 9, 2025
@dkocher dkocher added this to the 9.1.4 milestone Mar 9, 2025
@dkocher dkocher added the box Box Protocol Implementation label Mar 10, 2025
@dkocher dkocher mentioned this issue Mar 10, 2025
Merged
@dkocher
Copy link
Contributor

dkocher commented Mar 10, 2025

Regression from a11563b.

dkocher added a commit that referenced this issue Mar 10, 2025
@dkocher
Merge pull request #16930 from iterate-ch/bugfix/GH-16927
f14db78 
Skip trashed files in downloads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkocher dkocher

Labels
box Box Protocol Implementation googledrive Google Drive Protocol Implementation
Projects
None yet
Milestone
9.1.4
Development

Successfully merging a pull request may close this issue.

Skip trashed files in downloads iterate-ch/cyberduck
2 participants
@dkocher @ks-sst