Fix annoying donation panel

[cyberduck]

abhibeckert created the issue

The periodic "please donate" panel in Cyberduck is extremely annoying.

I love open source software, and am involved in more than one project myself (one of which has received thousands of dollars in donations), but I would never harass people the way Cyberduck does.

I'd like to see requests for donations become a lot more subtle (maybe a menu item, a prominent button on the website, and a prominent button in "new version available, install now?" messages.

I realise it costs money to create/distribute quality software, but if your project is good enough (and Cyberduck certainly is), then there's no need to nag people. The donations will come regardless, and plenty of them (I know this from first hand experience).

I'm almost annoyed enough to create a fork of the project without any such harassment.

[cyberduck]

@dkocher commented

We display the donation prompt when no donation key is found and

• When launching a newer version than previously opened.
• When you click Don't show again for this version it is displayed again nevertheless after 30 days.

There are no other limitations when using Cyberduck without any donation key or other visual reminders whatsoever.

[cyberduck]

f356366 commented

I checked the "Don't show again for this version" and clicked later, however it still asks me to donate every single time I quit the program. In the past it would only ask once per version. The window now prevents my Mac from shutting down until I handle it each time. Tried deleting the two config files and it didn't help.

[cyberduck]

4a6a1e3 commented

Like Tom, I get the nag screen even if I ask for it not to be shown again for this version.

[cyberduck]

@dkocher commented

This is a bug in 3.3 (refer to #3994) fixed in in 38678d5. Thanks for reporting this issue!