Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kSCPropNetProxiesExceptionsList processing ignored CIDR styled patterns #5142

Closed
cyberduck opened this issue Sep 7, 2010 · 6 comments
Closed

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Sep 7, 2010

c86e3f1 created the issue

In ch/cyberduck/core/SystemconfigurationProxy.m, in method

+ (BOOL)isHostExcluded:(NSString *)hostname

it ignores the CIDR styled pattern such as 192.168/16 or 172.16/16 or 10/8, would it be possible to include it? This will make proxy exception handling more complete.

Cheers,

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Sep 14, 2010

@dkocher commented

Can you provide a patch?

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 25, 2010

@dkocher commented

We should also better parse the setting for general hostnames.

  • To bypass a single domain, enter the domain name, for example, apple.com.
  • To bypass all websites on a domain, use an asterisk before the domain name, for example, *.apple.com.
  • To bypass a specific part of a domain, specify each part, for example, store.apple.com.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 25, 2010

@dkocher commented

We should also read kSCPropNetProxiesExcludeSimpleHostnames.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 25, 2010

@dkocher commented

Fix general failures to obey host exclusion setting for HTTP proxies in 9a2f85a.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 26, 2010

@dkocher commented

Replying to [5142 https://www.google.com/accounts/o8/id?id=aitoawlacyi7aiogipgx3ujwq77gimjemieww8s]:

it ignores the CIDR styled pattern such as 192.168/16 or 172.16/16 or 10/8, would it be possible to include it? This will make proxy exception handling more complete.

I can make use of SubnetUtil to detect these, but it will only recognize patterns matching n.n.n.n/m where n=1-3 decimal digits, m = 1-3 decimal digits in range 1-32.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Nov 26, 2010

@dkocher commented

In eafc74e.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants