kSCPropNetProxiesExceptionsList processing ignored CIDR styled patterns

[cyberduck]

c86e3f1 created the issue

In ch/cyberduck/core/SystemconfigurationProxy.m, in method

+ (BOOL)isHostExcluded:(NSString *)hostname

it ignores the CIDR styled pattern such as 192.168/16 or 172.16/16 or 10/8, would it be possible to include it? This will make proxy exception handling more complete.

Cheers,

[cyberduck]

@dkocher commented

Can you provide a patch?

[cyberduck]

@dkocher commented

We should also better parse the setting for general hostnames.

• To bypass a single domain, enter the domain name, for example, apple.com.
• To bypass all websites on a domain, use an asterisk before the domain name, for example, *.apple.com.
• To bypass a specific part of a domain, specify each part, for example, store.apple.com.

[cyberduck]

@dkocher commented

We should also read kSCPropNetProxiesExcludeSimpleHostnames.

[cyberduck]

@dkocher commented

Fix general failures to obey host exclusion setting for HTTP proxies in 9a2f85a.

[cyberduck]

@dkocher commented

Replying to [5142 https://www.google.com/accounts/o8/id?id=aitoawlacyi7aiogipgx3ujwq77gimjemieww8s]:

it ignores the CIDR styled pattern such as 192.168/16 or 172.16/16 or 10/8, would it be possible to include it? This will make proxy exception handling more complete.

I can make use of SubnetUtil to detect these, but it will only recognize patterns matching n.n.n.n/m where n=1-3 decimal digits, m = 1-3 decimal digits in range 1-32.

[cyberduck]

@dkocher commented

In eafc74e.