ACLs getting dropped when updating metadata

[cyberduck]

2602672 created the issue

Updating or removing metadata causes all ACLs (other than owner/full control) to be removed.

[cyberduck]

@dkocher commented

In fbb1558.

[cyberduck]

2602672 commented

This issue is still present in the latest 8111 build. Strangely it doesn't happen with every metadata change, but more often than not the ACLs still get dropped completely.

[cyberduck]

@dkocher commented

Replying to [comment:3 jabeler]:

This issue is still present in the latest 8111 build. Strangely it doesn't happen with every metadata change, but more often than not the ACLs still get dropped completely.

I cannot replicate this. Can you give me the exact steps and preconditions to follow that the ACL is still dropped.

[cyberduck]

2602672 commented

I did a bit more digging, and it seems to only happen when updating metadata for multiple files. Doing this drops the ACLs every time.

[cyberduck]

@dkocher commented

Replying to [comment:5 jabeler]:

I did a bit more digging, and it seems to only happen when updating metadata for multiple files. Doing this drops the ACLs every time.

I tried my best editing adding, editing and removing the metadata of multiple files but cannot see any changes to the ACLs.

[cyberduck]

2602672 commented

Here's what I did to replicate the issue.

1. Upload 4 files to a public bucket. File names: CF, CF2, CF3, CF4 (no file extensions). (After upload files will have default info of a metadata tag 'Content-type' equal to 'application/octet-stream' and ACLs of full control for myself and read permissions for everyone)

2. Highlight all 4 files, and add a meta tag of 'Expires' equal to 'Sat, 15 Jan 2029 03:35:01 MST'

3. The metadata tag will be updated, and all ACLs removed.

[cyberduck]

2602672 commented

Another thing I noticed which may be relevant.

If you view the files' ACLs pane (in info window) BEFORE changing the metadata the ACLs do not get dropped. However, if you select the metadata pane, highlight the files and change the metadata the ACLs get dropped.

[cyberduck]

@dkocher commented

Replying to [comment:8 jabeler]:

Another thing I noticed which may be relevant.

If you view the files' ACLs pane (in info window) BEFORE changing the metadata the ACLs do not get dropped. However, if you select the metadata pane, highlight the files and change the metadata the ACLs get dropped.

Thanks for hunting this down! Sure, that makes the difference.

[cyberduck]

@dkocher commented

Revised patch in f7d0226.