Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement resource locking #5687

Closed
cyberduck opened this issue Feb 3, 2011 · 11 comments
Closed

Implement resource locking #5687

cyberduck opened this issue Feb 3, 2011 · 11 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Feb 3, 2011

https://me.yahoo.com/gregjko#87241 created the issue

Though locking is one of the four core operations mentioned by the WebDAV RFC (the other three being properties, collections and namespace operations), Cyberduck doesn’t yet implement it.

https://tools.ietf.org/html/rfc2518#section-6

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 4, 2011

@dkocher commented

The issue here is to decide when to remove the lock. We don't know when will be the last edit (depending on the external editor application).

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented May 30, 2011

@dkocher commented

Some basic work has started in 87590c6e6c91fae576ff998d5dc39e12a89daf47 in Sardine.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 22, 2011

@dkocher commented

#5687 closed as duplicate.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 25, 2011

b22d385 commented

Hi, just wondering of which ticket this one is a duplicate ?
Sorry for my duplicate anyway (#6104), this feature is really a must have for my team to use cyberduck and I'd be happy to help implement.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 25, 2011

b22d385 commented

Regarding unlocking, I would say, timeout by default reissued if file is still in edition and a button to "try" an unlock arbitrarily)

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 26, 2011

@dkocher commented

#6104 closed as duplicate.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 26, 2011

@dkocher commented

Replying to [comment:6 Joseph Piron]:

Regarding unlocking, I would say, timeout by default reissued if file is still in edition and a button to "try" an unlock arbitrarily)

If implemented that would need to be transparent to the user.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 26, 2011

@dkocher commented

Replying to [comment:5 Joseph Piron]:

Hi, just wondering of which ticket this one is a duplicate ?
Sorry for my duplicate anyway (#6104), this feature is really a must have for my team to use cyberduck and I'd be happy to help implement.

No problem about a duplicate. The next step would be to overload all methods in the Sardine interface that need lock support to accept an additional lock parameter.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 26, 2015

a4e08d7 commented

Last week I sent the following question to support@mountainduck.io:

We are in the process of rolling out WebDAV support for developers using our CMS. As I explored the available options for WebDAV clients on both Windows and MacOS platforms, I stumbled across CyberDuck and your new Mountain Duck product. For collaborative development, however, the ability to lock files while you are editing them is critical, and virtually no WebDAV clients currently support locking that we've been able to find. We're especially looking for appropriate tools for our Mac users, since we haven't found any tools they can use to lock and unlock files on a WebDAV share while they are working on them. Are there any plans to support locking files on a WebDAV share in either your CyberDuck or Mountain Duck products?''

Today, David Kocher replied with the following:

Thanks for your interest in Mountain Duck! We do not currently support resource locking as there were implementation issues in Cyberduck with potential dangling locks after editing a file. In Mountain Duck this could be implemented properly I suppose. Please reopen and comment ticket [1] to allow us track the issue.''

So as requested I am now doing so. One simple option is to simply provide toolbar or menu functions to lock and unlock a file manually as a separate process from editing a file. While it is not as automated as automatically locking and unlocking a file while editing it, it at least exposes the functionality in a way that can be used.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Oct 26, 2015

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 1, 2018

@dkocher commented

More in a7dedeb.

Loading

@cyberduck cyberduck closed this Jan 13, 2019
@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants