Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows version] No option to disable Multipart Upload #5727

Closed
cyberduck opened this issue Feb 25, 2011 · 3 comments
Closed

[Windows version] No option to disable Multipart Upload #5727

cyberduck opened this issue Feb 25, 2011 · 3 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Feb 25, 2011

d6ff62f created the issue

Hi,

Could please implement a way to disable the multipart upload ?
Actually some S3 compliant providers doesn't support this feature so far .

Thanks

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2011

d6ff62f commented

For the sake of the completeness :
It looks like in this part of the code if the multipart failed that not retry in normal .

  this.getSession().message(MessageFormat.format(Locale.localizedString("Uploading {0}", "Status"),
                        this.getName()));

                if(this.getLocal().attributes().getSize() > DEFAULT_MULTIPART_UPLOAD_THRESHOLD) {
                    this.uploadMultipart(throttle, listener, object);
                }
                else {
                    // No Content-Range support
                    status().setResume(false);
                    this.uploadSingle(throttle, listener, object);
                }
            }
        }
        catch(ServiceException e) {
            this.status().setComplete(false);
            this.error("Upload failed", e);
        }
        catch(IOException e) {
            this.error("Upload failed", e);
        }


Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2011

@dkocher commented

We could easily disable multipart uploads for all endpoints that are not aws.amazon.com.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2011

@dkocher commented

In 792b10e.

Loading

@cyberduck cyberduck closed this Feb 25, 2011
@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants