FTP and SFTP passwords stored in keychain with incorrect protocol codes

[cyberduck]

14bafee created the issue

Cyberduck 2.6.1 (2376) stores FTP and SFTP passwords in the keychain with protocol constants that are not defined in SecKeychain.h. FTP passwords are stored with a code of 'ftp\000'; the correct code is kSecProtocolTypeFTP # 'ftp ' (with a space instead of a null). SFTP passwords are stored with 'sftp'; the correct code is kSecProtocolTypeSSH'ssh '.

Because of this bug other FTP/SFTP clients (such as Fetch) do not see passwords saved by Cyberduck, and vice-versa.

[cyberduck]

@dkocher commented

http://chenillebedspreads.org

[cyberduck]

@dkocher commented

As of da2a709.