Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability bug: Trainling slash in server name screws up custom ports #8385

Closed
cyberduck opened this issue Dec 2, 2014 · 2 comments
Closed

Usability bug: Trainling slash in server name screws up custom ports #8385

cyberduck opened this issue Dec 2, 2014 · 2 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Dec 2, 2014

6dd3a81 created the issue

I stumbled over the following problem:

When trying to open an sftp connection to server "myserver.example.com/" and port "33333" in the "Open Connection" panel, Cyberduck wrongly infers that the URL for the server is sftp://username@myserver.example.com/:33333/

I know the server name should't have the trailing slash in the first place, so one could blame the user. But I think this should be considered as a usability bug anyway. Adding a trailing slash can happen quickly and the result is unexpected.

Suggested behavior:

  • Since DNS names are not allowed to contain a forward slash, the trailing slash could be silently ignored (or even removed) by Cyberduck
  • Alternative: warn the user that no trailing slash should be used (I prefer the previous behavior)
@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jan 21, 2015

@dkocher commented

Tests in 3d261fc.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jan 22, 2015

@dkocher commented

In acb6555 and 308e2d9.

@cyberduck cyberduck closed this Jan 22, 2015
@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants