Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong timestamp in tempurl. Ticket #8384 fixed not correctly #8393

Closed
cyberduck opened this issue Dec 3, 2014 · 2 comments
Closed

Wrong timestamp in tempurl. Ticket #8384 fixed not correctly #8393

cyberduck opened this issue Dec 3, 2014 · 2 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Dec 3, 2014

f19f995 created the issue

Hello, in ticket #8384 was mentioned, that timestamp is generating not correctly. After fix, time stamp is generated:
'temp_url_expires=3600' which is not correct. It should be formatted in UNIX timestamp (seconds since Jan 01 1970 until now plus hour, week and etc. in seconds).

still using miliseconds not seconds in time stamp

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 3, 2014

@dkocher commented

Sorry for the additional regression. Fixed in 053e6d8.

Loading

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Dec 5, 2014

@dkocher commented

Fix and test in 1edf1ee.

Loading

@cyberduck cyberduck closed this Dec 5, 2014
@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants