Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files still get deleted when using "Overwrite" #9298

Closed
cyberduck opened this issue Feb 24, 2016 · 15 comments
Closed

Files still get deleted when using "Overwrite" #9298

cyberduck opened this issue Feb 24, 2016 · 15 comments

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Feb 24, 2016

23ffe81 created the issue

Files, that exists and would be overwritten (from remote to local) still get deleted on local!
This is critical and makes the FTP client unusable for our whole agency.

I thought this was fixed!

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

49b2b1c commented

I thought this was fixed too.
I am using the snapshot builds, so I am pretty sure that I am using the latest version, but I still have this issue.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

@dkocher commented

Do you refer to #9130?.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

23ffe81 commented

Yes, this is the described issue.
On some dublicate ticket of this issue someone created a time ago, it was said that it was resolved in the latest version.
Now I thought it would be fixed in 4.8, because it is crucial and makes it unusable.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

@dkocher commented

The issue is supposed to be fixed and I can no longer reproduce it here. The workaround would be to set the option Existing Files to Overwrite in Preferences → Transfers → Downloads.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

@dkocher commented

Can you confirm you are running version 4.8 (19033).

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

49b2b1c commented

I am on 4.8 (19026)
I set the updates to look for Snapshot Builds.
Now I see part of the problem: as steveooo pointed out, in one of the duplicate tickets someone wrote that switching to snapshot builds would solve the issue, and so I tried. However, snapshot builds got me as far as 19026, but now I tried to go back to "Release" and I got the update to 19033.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

@dkocher commented

Replying to [comment:6 miguelrogonzo]:

I am on 4.8 (19026)
I set the updates to look for Snapshot Builds.
Now I see part of the problem: as steveooo pointed out, in one of the duplicate tickets someone wrote that switching to snapshot builds would solve the issue, and so I tried. However, snapshot builds got me as far as 19026, but now I tried to go back to "Release" and I got the update to 19033.

There should be no difference between these builds regarding this issue.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

23ffe81 commented

I am on Version 4.8 (19033).

I think I got the bug:
When setting Existing Files to Overwrite in Preferences → Transfers → Downloads., like you said, it won't delete it.
IF I set it to Prompt (because I want it to ask me before doing something), then the options window with "Overwrite" preselected appears but then the files get removed!
So there is some issue with "Prompt" + "Overwrite"!

Can you reproduce it?

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 25, 2016

@dkocher commented

Replying to [comment:8 steveooo]:

I am on Version 4.8 (19033).

I think I got the bug:
When setting Existing Files to Overwrite in Preferences → Transfers → Downloads., like you said, it won't delete it.
IF I set it to Prompt (because I want it to ask me before doing something), then the options window with "Overwrite" preselected appears but then the files get removed!
So there is some issue with "Prompt" + "Overwrite"!

Can you reproduce it?

When choosing Overwrite in the prompt it will move the files to the Trash instead of overwriting. The bug was that trashing was delayed in a previous implementation used causing it to trash the newly downloaded file in some cases. This should no longer occur with the fix in f5afe20 but apparently this is still an issue for some.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 26, 2016

@dkocher commented

Disabled trash feature in 8cf896d.

@cyberduck cyberduck closed this Feb 26, 2016
@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 27, 2016

23ffe81 commented

Can this be released as a quick bugfix release and not for the next major release? Such think is crucial and makes Cyberduck it unusable for some people.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 27, 2016

@dkocher commented

Please update to the latest snapshot build available.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 29, 2016

23ffe81 commented

4.8.1 was released today. When will 4.8.2 with this bugfix be released?

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Feb 29, 2016

@dkocher commented

Replying to [comment:14 steveooo]:

4.8.1 was released today. When will 4.8.2 with this bugfix be released?
4.8.2 is now available.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Mar 1, 2016

23ffe81 commented

Thanks! It seems to work now!

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant