Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregistered button placement in full screen view #9554

Closed
cyberduck opened this issue May 20, 2016 · 3 comments
Closed

Unregistered button placement in full screen view #9554

cyberduck opened this issue May 20, 2016 · 3 comments
Assignees
Milestone

Comments

@cyberduck
Copy link
Collaborator

cyberduck commented May 20, 2016

0f583b3 created the issue

Steps to reproduce:

  1. Open Cyberduck full screen on OS X with another app on the second half of the screen.
  2. Observe the Unregistered button

Expected:
The button is clearly visible

Actual:
The button is hidden behind the interface

Cyberduck: Version 5.0 (20118)
OS X: 10.11.5 (15F34)


Attachments

@cyberduck
Copy link
Collaborator Author

cyberduck commented May 23, 2016

@dkocher commented

We should use the new NSTitlebarAccessoryViewController API.

@cyberduck
Copy link
Collaborator Author

cyberduck commented May 23, 2016

@dkocher commented

This should also resolve

2016-05-23 13:38:13.141 Cyberduck[75998:13217226] NSWindow warning: adding an unknown subview: <NSButton: 0x7fd58c85b730>. Break on NSLog to debug.
2016-05-23 13:38:13.142 Cyberduck[75998:13217226] Call stack:
(
	0   AppKit                              0x00007fff93a4a8bb -[NSThemeFrame addSubview:] + 107
	1   libjnidispatch.dylib                0x000000011ed4f134 ffi_call_unix64 + 76
	2   ???                                 0x00007fff57b1d0f8 0x0 + 140734664659192
)


@cyberduck
Copy link
Collaborator Author

cyberduck commented Aug 24, 2016

@dkocher commented

In 94c64ab.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants