Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomfirmed reads are unbounded #9603

Closed
cyberduck opened this issue Jun 20, 2016 · 1 comment
Closed

Uncomfirmed reads are unbounded #9603

cyberduck opened this issue Jun 20, 2016 · 1 comment
Assignees
Labels
enhancement fixed sftp version:5.0
Milestone

Comments

@cyberduck
Copy link
Collaborator

@cyberduck cyberduck commented Jun 20, 2016

97b83bd created the issue

If the file being downloaded is very large the number of unconfirmed reads is effectively unbounded. For example, when the file is 1.3GB, the number of unconfirmed reads is set to 39K. This results in the client submitting 39K calls to the server, updating the progress to look like the download is done, and then failing when some of the calls don't get responses in time. As far as I can tell, there is no way for the server to push back against these requests. As such, Cyberduck should limit the number of unconfirmed reads to something more reasonable, for example 1K.

FYI, the command like SFTP client supports 64 unconfirmed requests by default:

~ ❯❯❯ sftp -R                                                                                                                
 -- number of outstanding requests (default: 64)

Capping this at a reasonable number like 64 also means that when you click "stop" that it stops very quickly rather than taking a while to drain all of the unconfirmed reads.

@cyberduck
Copy link
Collaborator Author

@cyberduck cyberduck commented Jul 15, 2016

@dkocher commented

In c73455f.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement fixed sftp version:5.0
Projects
None yet
Development

No branches or pull requests

2 participants