Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception connecting to bookmark with whitespace in default path #9612

Closed
cyberduck opened this issue Jun 30, 2016 · 23 comments
Closed

Exception connecting to bookmark with whitespace in default path #9612

cyberduck opened this issue Jun 30, 2016 · 23 comments
Assignees
Labels
Milestone

Comments

@cyberduck
Copy link
Collaborator

cyberduck commented Jun 30, 2016

11d6cb2 created the issue

Steps to reproduce:

  1. Connect to an iRODS Zone using the iRODS protocol
  2. Navigate to a collection in the Browser
  3. With a collection highlighted in the Browser, press CTRL+SHIFT+B to create a new bookmark
  4. Assign a Nickname in the resulting new bookmark dialog, observing that the Path field now includes the path to the collection
  5. Close the new bookmark dialog
  6. Double-click the new bookmark from the Bookmarks list
  7. An error dialog is generated, reporting:
   "Connection failed
    Cannot convert this account into a URI:irods://..."

Test environment:

  • Cyberduck 5.0.3 on Microsoft Windows 7 Enterprise Service Pack 1 64-bit
  • iRODS server Release Version rods4.1.6, API Version = d

Attachments

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jun 30, 2016

11d6cb2 commented

Note that this issue also seems to appear when Preferences, General, Browser, Save Workspace is checked. In that case, closing Cyberduck from an active iRODS connection and restarting it will produce the connection failed error at startup.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 1, 2016

@dkocher commented

Can you please attach the connection profile you are using. If you have multiple profiles installed, make sure the Vendor is different for each.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 1, 2016

@dkocher commented

Looks similar to this upstream issue.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 1, 2016

@dkocher commented

I cannot reproduce this error.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 6, 2016

11d6cb2 commented

Replying to [comment:4 dkocher]:

Looks similar to this upstream issue.

Test test environment is using iRODS 4.1.6 which appears to include the patch for upstream issue 48.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 6, 2016

11d6cb2 commented

Replying to [comment:3 dkocher]:

Can you please attach the connection profile you are using. If you have multiple profiles installed, make sure the Vendor is different for each.
I verified that this behavior persists after ensuring the Vendor string is unique for the profile. That fix did work-around issue #9615, but did not fix the case of a bookmark having a path other than "/".

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 15, 2016

@dkocher commented

Can you post the full error message starting with Cannot convert this account into a URI:irods://….

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 15, 2016

@dkocher commented

Can you please attach the connection profile and the bookmark created from the profile with the custom path.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 15, 2016

11d6cb2 commented

Replying to [comment:10 dkocher]:

Can you post the full error message starting with Cannot convert this account into a URI:irods://….

"Cannot convert this account into a URI:irods://user8439@irods.test.com:1247."

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 15, 2016

11d6cb2 commented

I found that I could get the bookmark to work as expected in the case of the collection path not having any spaces in it. It seems that if I bookmark a path that does have a space in a collection name, then I do get the behavior described in this ticket. Perhaps this issue is limited only to the case of bookmarks containing spaces in the path?

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 18, 2016

@dkocher commented

In 89eaf3e.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 18, 2016

@dkocher commented

Upstream issue #189.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 25, 2016

11d6cb2 commented

This issue persists in release 5.0.9.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 27, 2016

@dkocher commented

I cannot reproduce the error anymore. What is the error message displayed?

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 27, 2016

11d6cb2 commented

I have attached a screenshot with the error message.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 28, 2016

@dkocher commented

Can you verify again you are running version 5.0.9 on Windows?

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 28, 2016

11d6cb2 commented

I have attached a screenshot of the About dialog in the Cyberduck instance used for testing. It reports Version 5.0.9 (20675) and is running on a Microsoft Windows 7 Enterprise Service Pack 1 64-bit Operating System.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Jul 31, 2016

@dkocher commented

Please let me know the exact steps to follow to reproduce the issue.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Aug 4, 2016

76107c1 commented

Using Cyberduck V 5.1.0 (20676)

I reproduced the problem with spaces in bookmark paths for both iRODS /PAM and WebDAV connections.
It appears that you are not encoding the path for the URL (spaces remain as spaces instead of %20)

Paths with folder names without spaces works; if the folder name has a space --
iRODS fails with

Connection failed /    Cannot convert this account into a URI:irods://..."

WebDAV fails with error below (position 63 is where the first space is).

[Window Title]
Error

[Main Instruction]
Connection failed

[Content]
Invalid redirect URI: http://rndsharepoint.dow.com/sites/IR/ripilot/ELNDeploy/Project Documents/Forms/AllItems.aspx. Illegal character in path at index 63: http://rndsharepoint.dow.com/sites/IR/ripilot/ELNDeploy'/Project Documents/Forms/AllItems.aspx.

In both cases, the URL that is showning the dialog (and in the bookmark file) has spaces in it (not %20's) .

In the case of the sharepoint connection , this path works:
/sites/IR/ripilot/ELNDeploy/

When I try to type a space as part of the path, the space does not appear unless I back arrow and re-insert it. That tells me it is suggesting that spaces are not acceptable. A single "&" is not shown in the URL but "&&" shows a single "&".

@cyberduck
Copy link
Collaborator Author

cyberduck commented Aug 4, 2016

76107c1 commented

On the other hand... spaces in a folder name are handled properly in Google Drive.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Aug 22, 2016

@dkocher commented

Replying to [comment:26 mihondo]:

The issue with the Sharepoint server is a different server side error. The server rndsharepoint.dow.com is responding with a HTTP redirect with a URL that is not properly encoded and therefore invalid. Please check the transcript from the log drawer.

@cyberduck
Copy link
Collaborator Author

cyberduck commented Aug 24, 2016

@dkocher commented

I can no longer reproduce this issue with version 5.0.11 and snapshot build 5.1.0 (20852).

@cyberduck
Copy link
Collaborator Author

cyberduck commented Aug 24, 2016

@dkocher commented

Please share the bookmark that is still giving the failure on attempting to open a connection.

@iterate-ch iterate-ch locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants