Auto-updater ignores custom installation locations on Windows

[cyberduck]

a3908d4 created the issue

Details

The Cyberduck Windows installer accepts custom installation locations: Providing an installation path like e.g. D:\Program Files (x86)\iterate\Cyberduck within the installer's GUI is definitely possible.

Once Cyberduck is installed, however, and a new version number gets available through the auto-updater, the auto-update feature ignores custom installation locations and updates any Cyberduck installation to %ProgramFiles(x86)%\Cyberduck, no matter which installation path was initially chosen on setup. In the end, this results in two Cyberduck instances on the very same machine:

• The remaining old version in the custom installation path provided in the initial setup,

• The new up-to-date version in %ProgramFiles(x86)%\Cyberduck.

-Reproducibility*

• Install any Cyberduck version for Windows prior to the current 5.2.3 (21496) and provide a custom installation location on this initial setup, e.g. C:\Program Files (x86)\iterate\Cyberduck.

• Once this older Cyberduck version for Windows is installed, start it and choose Help → Check for Update….
• When the update to the current Cyberduck version is detected, install it: No matter which installation location you provided in step 1, the up-to-date Cyberduck version just installed by the auto-update will reside in %ProgramFiles(x86)%\Cyberduck.

-See also*

As of version 1.6.3 (5079), the Mountain Duck auto-updater shows the very same behaviour.

[cyberduck]

@dkocher commented

Similiar report for the Cyberduck CLI installer

The CLI installer (windows) has an "options" button that purports to allow changing the destination directory. It happily accepts a new directory for the install, then ignores it and installs to the default location. If you are not going to allow one to choose the install location, don't put the option button in the installer! But I'd rather you fix it so the installer honors the new location. (The default location is a path with many spaces in it, which is inconvenient for CLI work. It is also on the C:\ drive, which in many cases is a smaller SSHD device, so many of us try to install as much as possible to other volumes.)

[cyberduck]

@dkocher commented

Milestone renamed

[cyberduck]

@dkocher commented

Ticket retargeted after milestone closed

[cyberduck]

@dkocher commented

Ticket retargeted after milestone closed

[cyberduck]

@dkocher commented

In 814f887.

[cyberduck]

@dkocher commented

Milestone renamed