Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS S3 sso_session configuration #14568

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

yuzawa-san
Copy link
Contributor

mirrored the boto cache key code (link in code comment) to use sso_session instead of sso_start_url. this is backwards compatible since it is conditional based on what is the config properties.

fixes #14276

@yuzawa-san yuzawa-san requested a review from a team as a code owner April 23, 2023 18:50
@dkocher dkocher added the s3 AWS S3 Protocol Implementation label Apr 24, 2023
@dkocher dkocher added this to the 8.6.0 milestone Apr 24, 2023
@dkocher
Copy link
Contributor

dkocher commented Apr 24, 2023

Could you rebase to master, I had to revert publishing tests results which fail for pull requests with Resource not accessible by integration.

@dkocher dkocher merged commit 5739f20 into iterate-ch:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s3 AWS S3 Protocol Implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new AWS SSO Profile configuration format
2 participants