Add preference for "Save in Keychain" when unlocking vaults#14662
Merged
Conversation
AliveDevil
requested changes
May 15, 2023
Contributor
AliveDevil
left a comment
AliveDevil
left a comment
There was a problem hiding this comment.
What's the state here1?
There is conflicting/duplicate usage now on "cryptomator.keychain" and "vault.keychain".
Footnotes
dkocher
force-pushed
the
feature/GH-11694-keychain
branch
from
dc224bb to
1b5a3fb
Compare
… when unlocking vaults.
dkocher
force-pushed
the
feature/GH-11694-keychain
branch
from
1b5a3fb to
a08a7c3
Compare
AliveDevil
approved these changes
May 19, 2023
ylangisc
approved these changes
May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11694.