Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference for "Save in Keychain" when unlocking vaults #14662

Merged
merged 7 commits into from
May 22, 2023

Conversation

dkocher
Copy link
Contributor

@dkocher dkocher commented May 11, 2023

Fix #11694.

@dkocher dkocher added this to the 8.6.0 milestone May 11, 2023
@dkocher dkocher requested a review from a team as a code owner May 11, 2023 09:44
@dkocher dkocher marked this pull request as draft May 11, 2023 09:44
Copy link
Contributor

@AliveDevil AliveDevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the state here1?

There is conflicting/duplicate usage now on "cryptomator.keychain" and "vault.keychain".

Footnotes

  1. https://github.com/iterate-ch/cyberduck/blob/465be7018aeeca4dc2bf6161d9ce83824460004c/core/src/main/java/ch/cyberduck/core/vault/VaultCredentials.java#LL30C50-L30C51

@dkocher dkocher marked this pull request as ready for review May 15, 2023 08:55
@dkocher dkocher requested a review from AliveDevil May 15, 2023 08:55
@dkocher dkocher marked this pull request as draft May 15, 2023 09:06
@dkocher dkocher force-pushed the feature/GH-11694-keychain branch from dc224bb to 1b5a3fb Compare May 16, 2023 12:00
@dkocher dkocher force-pushed the feature/GH-11694-keychain branch from 1b5a3fb to a08a7c3 Compare May 16, 2023 12:41
@dkocher dkocher marked this pull request as ready for review May 16, 2023 13:44
@dkocher dkocher requested a review from ylangisc May 17, 2023 12:04
@ylangisc ylangisc merged commit dd421a1 into master May 22, 2023
@ylangisc ylangisc deleted the feature/GH-11694-keychain branch May 22, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to uncheck Save Password by default when unlocking vault
3 participants