Apply suggestions from code review

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
iteratec · May 8, 2019 · 2685967 · 2685967
1 parent 31393e3
commit 2685967
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...selection/components/result-selection-job-group/result-selection-job-group.component.html b/...selection/components/result-selection-job-group/result-selection-job-group.component.html
@@ -1,7 +1,6 @@
 <div class="card form-horizontal">
   <h2>{{ 'frontend.de.iteratec.osm.resultSelection.jobGroup.title' | translate }}</h2>
-  <div class="form-group">
-    <select multiple class="form-control" id='job-groups-selection'>
+    <select multiple class="form-control" id='job-groups-selection' [(ngModel)]="selectedJobGroups">
       <ng-container *ngIf="!isEmpty; else elseBlock" >
           <option  *ngFor="let jobGroup of filteredJobGroups" [ngValue]="jobGroup.id" >
               {{jobGroup.name}}
@@ -13,12 +12,10 @@ <h2>{{ 'frontend.de.iteratec.osm.resultSelection.jobGroup.title' | translate }}<
           </option>
       </ng-template>
     </select>
-  </div>
 
 
-    <button class="btn btn-xs btn-default filter-button" id="filterBtn" *ngFor="let tag of selectableTags" (click)="filterByTag(tag)" [ngClass]="{'active': isSelected&&selectedTag===tag}">
+    <button class="btn btn-xs btn-default filter-buttons" id="filterBtn" *ngFor="let tag of selectableTags" (click)="filterByTag(tag)" [ngClass]="{'active': isSelected&&selectedTag===tag}">
       <i class="fas fa-filter"></i>
       &nbsp;{{tag}}
   </button>
-  </div>
 </div>
diff --git a/...t-selection/components/result-selection-job-group/result-selection-job-group.component.ts b/...t-selection/components/result-selection-job-group/result-selection-job-group.component.ts
@@ -16,13 +16,14 @@ import { Observable } from 'rxjs';
   })
 
 export class ResultSelectionJobGroupComponent {
-  @Input() jobGroupMappings$: Observable<SelectableApplication[]>;  
+jobGroupMappings$: Observable<SelectableApplication[]>;  
   jobGroups: SelectableApplication[];
   isEmpty = true;
   selectableTags: string[];
   filteredJobGroups: SelectableApplication[];
   selectedTag: string ='';
   isSelected = false;
+  selectedJobGroups: number[] = [];
 
   constructor(private resultSelectionService: ResultSelectionService) {
     this.jobGroupMappings$ = this.resultSelectionService.applications$;