Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IT-2649] Time Frame Selection as Angular component #179

merged 19 commits into from May 16, 2019


None yet
4 participants
Copy link

commented Apr 2, 2019

The time frame selection for the result charts is now built as an Angular component and will replace the existing gsp template when all other components for the result charts are built as an Angular component as well. The data will be initially fetched from the backend by the component created in IT-2647. The selected time frame will determine the data that the other components for the result charts get.

finnmartens and others added some commits Mar 4, 2019

[IT-2647] Added models for the result selection service and methods f…
…or communication with the ResultSelectionController.
[IT-2647] Only include used parameters in the service and added model…
…s for charts and jobgroups with pages.
Merge develop into feature/angularModuleForResultSelection
# Conflicts:
#	frontend/src/app/modules/result-selection/result-selection.module.ts
#	frontend/src/app/modules/result-selection/services/result-selection.service.spec.ts
#	frontend/src/app/modules/result-selection/services/result-selection.service.ts
#	grails-app/i18n/
#	grails-app/i18n/

finnmartens added some commits May 7, 2019

[IT-2649] Removed reference to currently disabled component, all para…
…ms other than dates are now optional and aggregation and comparative selection can now be triggered.
Merge remote-tracking branch 'origin/develop' into feature/angularMod…

# Conflicts:
#	grails-app/i18n/
#	grails-app/i18n/
@@ -3,9 +3,16 @@ import {HttpClient} from "@angular/common/http";
import {combineLatest, EMPTY, Observable, OperatorFunction, ReplaySubject} from "rxjs";

This comment has been minimized.

Copy link

PhilAlbrecht May 15, 2019


Could you check unused code please.

@sburnicki sburnicki merged commit 164dce9 into develop May 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed

sburnicki added a commit that referenced this pull request May 16, 2019

Merge pull request #196 from iteratec/feature/angularResultSelection
Feature: Angular result selection (merged)
This includes #179, #184, #186 and #191

@sburnicki sburnicki deleted the feature/angularModuleForResultSelection branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.