Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/angular module for job group selection #184

Merged
merged 27 commits into from May 16, 2019

Conversation

Projects
None yet
4 participants
@jiayiw5
Copy link
Contributor

commented May 3, 2019

The job group selection for the result charts is now built as an Angular component and will replace the existing gsp template when all other components for the result charts are built as an Angular component as well. The data will be initially fetched from the backend by the component created in IT-2647. The applications available in the selected time frame will be displayed and these can be filtered by the corresponding tags.

finnmartens and others added some commits Mar 4, 2019

[IT-2647] Added models for the result selection service and methods f…
…or communication with the ResultSelectionController.
[IT-2647] Only include used parameters in the service and added model…
…s for charts and jobgroups with pages.
Merge develop into feature/angularModuleForResultSelection
# Conflicts:
#	frontend/src/app/modules/result-selection/result-selection.module.ts
#	frontend/src/app/modules/result-selection/services/result-selection.service.spec.ts
#	frontend/src/app/modules/result-selection/services/result-selection.service.ts
#	grails-app/i18n/messages.properties
#	grails-app/i18n/messages_de.properties
jiayi
jiayi
jiayi
@finnmartens
Copy link
Contributor

left a comment

Looks good, I have some minor requests and if you want you could also rename the component and it's variables to Application instead JobGroup.

finnmartens and others added some commits May 8, 2019

Update frontend/src/app/modules/result-selection/components/result-se…
…lection-job-group/result-selection-job-group.component.ts

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Update frontend/src/app/modules/result-selection/components/result-se…
…lection-job-group/result-selection-job-group.component.ts

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Update frontend/src/app/modules/result-selection/components/result-se…
…lection-job-group/result-selection-job-group.component.ts

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Update frontend/src/app/modules/result-selection/result-selection.com…
…ponent.html

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Update frontend/src/app/modules/result-selection/components/result-se…
…lection-job-group/result-selection-job-group.component.html

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Update frontend/src/app/modules/result-selection/components/result-se…
…lection-job-group/result-selection-job-group.component.html

Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Apply suggestions from code review
Co-Authored-By: jiayiw5 <32901577+jiayiw5@users.noreply.github.com>
Fix typo
Co-Authored-By: Finn Martens <36506629+finnmartens@users.noreply.github.com>
@finnmartens
Copy link
Contributor

left a comment

Thank you for the changes!

@sburnicki sburnicki merged commit 168b635 into develop May 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

sburnicki added a commit that referenced this pull request May 16, 2019

Merge pull request #196 from iteratec/feature/angularResultSelection
Feature: Angular result selection (merged)
This includes #179, #184, #186 and #191

@sburnicki sburnicki deleted the feature/angularModuleForJobGroupSelection branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.