Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Measurands Selection as Angular component (Result Selection) #191

Merged
merged 21 commits into from May 16, 2019

Conversation

Projects
None yet
3 participants
@DanielSteger
Copy link
Contributor

commented May 14, 2019

The measurands selection for the result charts is built as an Angular component.

finnmartens and others added some commits Mar 4, 2019

[IT-2647] Added models for the result selection service and methods f…
…or communication with the ResultSelectionController.
[IT-2647] Only include used parameters in the service and added model…
…s for charts and jobgroups with pages.
Merge develop into feature/angularModuleForResultSelection
# Conflicts:
#	frontend/src/app/modules/result-selection/result-selection.module.ts
#	frontend/src/app/modules/result-selection/services/result-selection.service.spec.ts
#	frontend/src/app/modules/result-selection/services/result-selection.service.ts
#	grails-app/i18n/messages.properties
#	grails-app/i18n/messages_de.properties
[IT-2649] Removed reference to currently disabled component, all para…
…ms other than dates are now optional and aggregation and comparative selection can now be triggered.
Merge remote-tracking branch 'origin/develop' into feature/angularMod…
…uleForResultSelection

# Conflicts:
#	grails-app/i18n/messages.properties
#	grails-app/i18n/messages_de.properties
@sburnicki
Copy link
Member

left a comment

Looks good in general, I just have one question (see comment)

}
});

this.resultSelectionService.userTimings$.subscribe(next => {

This comment has been minimized.

Copy link
@sburnicki

sburnicki May 15, 2019

Member

Why are these two blocks necessary?

@sburnicki sburnicki merged commit 9ec0d3b into develop May 16, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

sburnicki added a commit that referenced this pull request May 16, 2019

Merge pull request #196 from iteratec/feature/angularResultSelection
Feature: Angular result selection (merged)
This includes #179, #184, #186 and #191

@sburnicki sburnicki deleted the feature/angularMeasurandsResultSelection branch May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.