add files.GetContentIOBuffer #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shcheklein merged 15 commits into master from iobuffer

May 30, 2020

Contributor

casperdcl commented May 17, 2020 •

edited

Loading

add GetContentIOBuffer returning a read()able object
- add mimetype
- add encoding
- add __iter__ to make it easier to wrap à la https://github.com/iterative/dvc/blob/516d82e41107438756797611bbb15614cd4d989f/dvc/utils/http.py#L66
- add remove_bom
~~add SetContentIOBuffer returning a write()able object~~
test
fixes add Get/SetContentIOBuffer #38


          add files.GetContentIOBuffer

09d6574

Fixes #38

casperdcl added the enhancement label

casperdcl requested a review from shcheklein

May 17, 2020 19:10

casperdcl self-assigned this

casperdcl commented

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

shcheklein reviewed

View reviewed changes

pydrive2/files.py Outdated Show resolved Hide resolved

casperdcl added 4 commits

May 25, 2020 01:03


          files: tidy and abstract common wrapper

61dbf8f


          add encoding param

fdfd90b


          mode decode to IoBuffer

da33215


          remove read(chunksize) for now

0b08569

- see 
#39 (comment)

casperdcl commented

View reviewed changes

pydrive2/files.py Show resolved Hide resolved

efiop mentioned this pull request

"AttributeError: NoneType object has no attribute 'wdir'" on dvc get-url call treeverse/dvc#3897

Closed

casperdcl added 5 commits

May 30, 2020 19:42


          add files.MediaIoReadable.__iter__

23cb534


          add files.GetContentIOBuffer(remove_bom)

73f0c81


          tidy remove_bom

dbfa5d9


          test GetContentIOBuffer

c550cd0


          fix GetBOM usage

casperdcl force-pushed the iobuffer branch from 00e7bca to 5101425 Compare

May 30, 2020 20:19

casperdcl marked this pull request as ready for review

May 30, 2020 20:19

casperdcl added 2 commits

May 30, 2020 21:25


          misc tidy

b561de2


          test GetContentIOBuffer(remove_bom)

3bff25a

casperdcl mentioned this pull request

api: support streaming from Google Drive remotes treeverse/dvc#3408

Closed

1 task

casperdcl added 3 commits

May 30, 2020 22:02


          fix error handling

e7ee078


          fix tests encoding


          silly assertion fix

712c571

casperdcl force-pushed the iobuffer branch from e87972b to 712c571 Compare

May 30, 2020 21:27

shcheklein merged commit f2d4458 into master

casperdcl deleted the iobuffer branch

May 30, 2020 21:46

This was referenced May 30, 2020

add len(MediaIoReadable) #40

Merged

gdrive: add open treeverse/dvc#3916

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels