Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kubernetes arbitrary node selector #1370

Merged
merged 6 commits into from
Jun 3, 2023
Merged

Add support for Kubernetes arbitrary node selector #1370

merged 6 commits into from
Jun 3, 2023

Conversation

ludelafo
Copy link
Contributor

@ludelafo ludelafo commented Apr 4, 2023 •
edited
Loading

This PR implements the Kubernetes arbitrary node selector described in issue #1365.

This is a work in progress and my first experience with Golang and Terraform provider development, I'm open to improvements.

Related PRs:

This was referenced Apr 4, 2023
Merged
Merged
@ludelafo ludelafo marked this pull request as draft April 4, 2023 08:29
@ludelafo ludelafo marked this pull request as ready for review April 6, 2023 08:17
@dacbd
Copy link
Contributor

dacbd commented Apr 7, 2023

@ludelafo can you provide an simple example command of at least 2 cases/values a user list:

cml runner launch \
    ... \
    --cloud-kubernetes-nod-selector xxx

dacbd
dacbd suggested changes Apr 7, 2023
View reviewed changes
bin/cml/runner/launch.js Outdated Show resolved Hide resolved
bin/cml/runner/launch.js Outdated Show resolved Hide resolved
@dacbd dacbd added cml-runner Subcommand cloud-k8s Kubernetes labels Apr 7, 2023
@ludelafo
Copy link
Contributor Author

ludelafo commented Apr 11, 2023 •
edited
Loading

@ludelafo can you provide an simple example command of at least 2 cases/values a user list:

cml runner launch \
    ... \
    --cloud-kubernetes-nod-selector xxx

@dacbd, I have added examples in my PR related to the cml.dev documentation website: https://github.com/iterative/cml.dev/pull/464/files#diff-326eb0b25030b7c788dc39eef79ebc9053a2e3207ed9d6e71904df2cf4d7e51aR379-R428

Please let me know if that works for you.

@ludelafo ludelafo marked this pull request as draft April 12, 2023 09:53
ludelafo
ludelafo commented Apr 12, 2023
View reviewed changes
bin/cml/runner/launch.js Outdated Show resolved Hide resolved
@ludelafo ludelafo marked this pull request as ready for review April 12, 2023 16:33
@ludelafo
Remove default value for --cloud-kubernetes-node-selector argument. I…
eafe3db 
…t will be set on the Terraform Provider Iterative side.
@ludelafo ludelafo temporarily deployed to external April 17, 2023 09:46 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Test Comment

@ludelafo ludelafo temporarily deployed to external May 4, 2023 17:47 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

Test Comment

@dacbd
Copy link
Contributor

dacbd commented May 9, 2023

@ludelafo, just a quick update for you, there seems to be an issue with our tests with one of our dependencies unrelated to any of the open PRs, and I want to make sure we have it resolved before building a new release. Unfortunately, it's not the highest priority for us ATM. @0x2b3bfa0 or I will try to resolve it soon, and we should be able to get this merged and a new release made immediately after.

Thanks for your patience.

@ludelafo
Copy link
Contributor Author

@ludelafo, just a quick update for you, there seems to be an issue with our tests with one of our dependencies unrelated to any of the open PRs, and I want to make sure we have it resolved before building a new release. Unfortunately, it's not the highest priority for us ATM. @0x2b3bfa0 or I will try to resolve it soon, and we should be able to get this merged and a new release made immediately after.

Thanks for your patience.

No worries! Thanks for the update.

If I can be of any help, please let me know!

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to external June 3, 2023 00:04 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to external June 3, 2023 00:56 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Test Comment

@0x2b3bfa0 0x2b3bfa0 merged commit 2598d06 into iterative:master Jun 3, 2023
@0x2b3bfa0
Copy link
Member

Sorry for the delay, @ludelafo; tests were broken because of multiple reasons (#1382 & #1383) unrelated to this pull request. 🙈

@ludelafo ludelafo deleted the add-support-for-kubernetes-arbitrary-node-selector branch June 5, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd dacbd approved these changes

Assignees

@ludelafo ludelafo

Labels
cloud-k8s Kubernetes cml-runner Subcommand
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ludelafo @dacbd @0x2b3bfa0