Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml #340

Closed
wants to merge 1 commit into from
Closed

Update pyproject.toml #340

wants to merge 1 commit into from

Conversation

yaellevy
Copy link

@yaellevy yaellevy commented Apr 2, 2023

This PR was send as part of osdc. taught by @szabgab

@efiop
Copy link
Contributor

efiop commented Apr 2, 2023

Hi @yaellevy , thanks for contributing. Could you please elaborate what is the purpose of this change? Not sure I understand what it does.

Comment on lines +92 to +95

authors = [
"J. David Ibáñez <jdavid.ibp@gmail.com>",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose you didn't mean to add it to the bandit section, but to the project section. We use dependencies that David maintains but I don't think David ever contributed to dvc-data, so I don't quite understand why you are adding him to the authors.

@efiop
Copy link
Contributor

efiop commented Apr 2, 2023

Oh, I see more PRs like these in other projects. So I suppose this is just a bot account. Closing.

@efiop efiop closed this Apr 2, 2023
@szabgab
Copy link

szabgab commented Apr 2, 2023

Hi @efiop,

This PR was sent by one of my students (not a bot) as part of the course in which they are learning how to contribute to open source projects. In this case they were asked to find python project that don't have the authors field that would be used on https://pypi.org/project/dvc-data/ in the Meta section. (see https://pypi.org/project/numpy/ that has it) They are using https://pydigger.com/ to find projects that don't have authors field and try to add it in a PR.

I am sorry if this caused a misunderstanding.

@efiop efiop mentioned this pull request Apr 2, 2023
2 tasks
@efiop
Copy link
Contributor

efiop commented Apr 2, 2023

@szabgab Oh, my bad. Ok, let's start with getting this PR through first and not create any more duplicate PRs in other iterative projects. I will be waiting for the response on the comments above.

@efiop efiop reopened this Apr 2, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c5ffd2) 57.66% compared to head (0be49f6) 57.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #340   +/-   ##
=======================================
  Coverage   57.66%   57.66%           
=======================================
  Files          51       51           
  Lines        3413     3413           
  Branches      597      597           
=======================================
  Hits         1968     1968           
  Misses       1359     1359           
  Partials       86       86           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skshetry
Copy link
Member

Closing as stale.

@skshetry skshetry closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants