-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml #340
Conversation
Add author
Hi @yaellevy , thanks for contributing. Could you please elaborate what is the purpose of this change? Not sure I understand what it does. |
|
||
authors = [ | ||
"J. David Ibáñez <jdavid.ibp@gmail.com>", | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose you didn't mean to add it to the bandit
section, but to the project
section. We use dependencies that David maintains but I don't think David ever contributed to dvc-data, so I don't quite understand why you are adding him to the authors.
Oh, I see more PRs like these in other projects. So I suppose this is just a bot account. Closing. |
Hi @efiop, This PR was sent by one of my students (not a bot) as part of the course in which they are learning how to contribute to open source projects. In this case they were asked to find python project that don't have the I am sorry if this caused a misunderstanding. |
@szabgab Oh, my bad. Ok, let's start with getting this PR through first and not create any more duplicate PRs in other iterative projects. I will be waiting for the response on the comments above. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
=======================================
Coverage 57.66% 57.66%
=======================================
Files 51 51
Lines 3413 3413
Branches 597 597
=======================================
Hits 1968 1968
Misses 1359 1359
Partials 86 86 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Closing as stale. |
This PR was send as part of osdc. taught by @szabgab