Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout: check if cache.type has changed #1371

Open
efiop opened this issue Nov 27, 2018 · 1 comment

Comments

@efiop
Copy link
Member

commented Nov 27, 2018

Same as in #1370 .

@efiop efiop added the enhancement label Nov 27, 2018

@efiop efiop added this to the Queue milestone Nov 27, 2018

@efiop

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

Related to #2358 where we already do that.

For checkout itself, we need to not rely in self.changed()(at least not in its current form, as it doesn't detect link/protected change) in RemoteBASE.checkout() but actually granularly check links. That could be done by modifying changed() so when it sees that self.state doesn't have a correct entry for the path_info, it goes ahead and not only checks the checksums, but also whether or not file is protected and is of correct link type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.