New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more git hooks (dvc pull/push/status) #1551
Comments
A new reason to prioritize this https://discordapp.com/channels/485586884165107732/485586884165107734/561380967311212554 |
Another question:
|
Good point @shcheklein ! Added p1 priority, we'll try to take a look at it next week. |
After some quick research I have following conclusions:
|
But not every
We already have post-checkot hook that simply runs |
Well we can use
According to documentation, git is supposed to pass flag whether it was branch or file, but it does not explicitly point which file. So i have been too fast with saying that it is possible. To use that information we would need mechanism to find checked out files. I think it is better to keep |
But that one is going to be called not only on
Nice! Would it make sense to make our checkout hook not perform So for now, only Looks like even though some git hooks do suffice for some of our purposes, the support would still be far from perfect. Maybe having simple aliases like |
I must agree thats a bit of a bummer. We could solve amend vs rebase problem by reading flag passed by git, but problem "Was it pull or rebase" will remain unsolved. Both hooks (
I think we could do that, but then there is one problem left: what if checked out file was stage? In such case we should probably validate our stages against their outputs checksums.
I agree.
I think that this idea is the best in terms of versatility. We tried the other way around (git hooks) and we already have problems with covering our commands with avialable hooks. I think that handling and debugginig this on dvc side with |
For the record: agreed privately that we would implement |
@AlJohri |
I'm still interested in adding a
It seems like we can at least just implement it for the I think the majority of users just use |
+1 for adding a |
can we add more git hooks for dvc pull/push/status when git pull/push/status are run? ideally, most git commands would have a hook. this will make it much less likely for someone to forget to
dvc push
after running a pipelineThe text was updated successfully, but these errors were encountered: