Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: Suggest to use `dvc add folder/` instead of irregular `dvc add -R` for large amount of files #1758

Closed
ei-grad opened this issue Mar 21, 2019 · 7 comments

Comments

3 participants
@ei-grad
Copy link
Contributor

commented Mar 21, 2019

Related #1756

@efiop efiop changed the title Suggest to use `dvc add folder/` instead of irregular `dvc add -R` for large amount of files add: Suggest to use `dvc add folder/` instead of irregular `dvc add -R` for large amount of files Mar 21, 2019

@efiop

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Or maybe it is worth renaming it into something else than --recursive to break association with cp.

@ei-grad

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

But is it needed at all?

@efiop

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@ei-grad that is also a great question :) We do have a user that indirectly requested it #1026 . Need to re-think this case.

@ei-grad

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

That one could be better solved by dvc add -u as of my opinion, to be honest. But anyway just removing the -R option is not an option now.

@ei-grad

This comment has been minimized.

Copy link
Contributor Author

commented Mar 27, 2019

The point is more about to don't touch the dvc add -R, but add a suggestion to use dvc add folder where it worth.

@efiop

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Could you elaborate on dvc add -u, please?

I agree about not removing it. I just threw in a thought that if it is indeed needed, maybe it is worth thinking about renaming it. A suggestion to use dvc add directory also seems good to me.

@ei-grad

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

We do have a user that indirectly requested it #1026

That one could be better solved by dvc add -u

Could you elaborate on dvc add -u, please?

The actual request in #1026 was to provide an ability to dvc add all the changed files in one command. This is what git add -u does for git repository.

@efiop efiop added this to To do in Weekly tasks via automation Apr 25, 2019

mroutis added a commit to mroutis/dvc that referenced this issue Apr 25, 2019

@mroutis mroutis moved this from To do to In progress in Weekly tasks Apr 25, 2019

@mroutis mroutis referenced this issue Apr 25, 2019

Merged

add: warn when recursively adding large files #1935

2 of 2 tasks complete

mroutis added a commit to mroutis/dvc that referenced this issue Apr 25, 2019

mroutis added a commit to mroutis/dvc that referenced this issue Apr 30, 2019

mroutis added a commit to mroutis/dvc that referenced this issue Apr 30, 2019

@efiop efiop closed this in #1935 Apr 30, 2019

Weekly tasks automation moved this from In progress to Done Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.