Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvc metrics show - implement jsonpath-ng instead of python-jsonpath-rw #1919

Closed
brbarkley opened this issue Apr 23, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@brbarkley
Copy link
Contributor

commented Apr 23, 2019

Hello,

For passing JSONPath to dvc metrics show is it possible to use jsonpath-ng under the hood instead of python-jsonpath-rw?

jsonpath-ng seems to more fully support JSONPath features, for example the ability to filter on certain values: $..book[?(@.price<10)] which would be useful for comparing metrics with greater specificity from dvc metrics files.

Thanks for considering!

@efiop

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Hi @brbarkley !

Great question! I don't quite remember why we've opted for python-jsonpath-rw. Looks like we could simply start using jsonpath-ng instead and we should be fine as long as tests pass. Would you like to submit a PR? 🙂

Thanks,
Ruslan

brbarkley added a commit to brbarkley/dvc that referenced this issue Apr 28, 2019

@brbarkley brbarkley referenced this issue Apr 28, 2019

Merged

dvc metrics show: implement jsonpath-ng #1944

2 of 2 tasks complete

brbarkley added a commit to brbarkley/dvc that referenced this issue Apr 28, 2019

dvc metrics show: implement jsonpath-ng
updated setup.py
updated test_metrics.py::assertMetricsHaveRelativePaths

Fixes iterative#1919

@efiop efiop closed this in #1944 Apr 28, 2019

@efiop

This comment has been minimized.

Copy link
Member

commented May 12, 2019

@brbarkley This feature was released as a part of 0.40.1. Please upgrade 🙂 Big thanks for the PR! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.