Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove: change default behaviour to `--purge`, port back patch from 1.0 branch #3317

Open
jorgeorpinel opened this issue Feb 13, 2020 · 4 comments

Comments

@jorgeorpinel
Copy link
Member

@jorgeorpinel jorgeorpinel commented Feb 13, 2020

dvc remote --outs is the default behavior so will this option ever be used?

@efiop

This comment has been minimized.

Copy link
Member

@efiop efiop commented Feb 13, 2020

It was meant for backward compatibility. We've planned to switch from it in 1.0 #763 and even have a patch there already. I guess we could consider switching it earlier. dvc remove needs some reconsideration in general, we are also thinking about it in terms of removing cache for a file, which is related to gc discussion.

@jorgeorpinel

This comment has been minimized.

Copy link
Member Author

@jorgeorpinel jorgeorpinel commented Feb 13, 2020

Gotcha. Feel free to close this if it's included in some other issue or you feel it's not really impactful. Thanks for the explanation though!

@efiop

This comment has been minimized.

Copy link
Member

@efiop efiop commented Feb 13, 2020

@jorgeorpinel Let's close it since it is fixed in 1.0 branch.

@efiop efiop closed this Feb 13, 2020
@efiop

This comment has been minimized.

Copy link
Member

@efiop efiop commented Feb 13, 2020

On second thought... It is so trivial to fix that it is not worth waiting for 1.0 and we've been breaking worse stuff previously, so no need to be overprotective here. Keeping it open.

@efiop efiop reopened this Feb 13, 2020
@efiop efiop added the ui label Feb 13, 2020
@efiop efiop changed the title remove: eliminate -o option? remove: change default behaviour to `--purge`, port back patch from 1.0 branch Feb 13, 2020
@efiop efiop added the p2-medium label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.