dvc: switch to flufl lock #2461
Conversation
This locks employs hardlink trick, which works on NFS and alike unlike fcntl/open locks. Closes treeverse#1918.
Suor
force-pushed
the
nfs
branch
2 times, most recently
from
de8d4e3 to
9111bf5
Compare
|
So things still might not work under Python 2 or very old sqlite3 version. Which is an issue than will solve itself ). |
|
@Suor FYI: tests on py2.7 on windows are failing. |
dvc/updater.py
Outdated
There was a problem hiding this comment.
You don't set lifetime here, is there some default value?
There was a problem hiding this comment.
Yes, 5 seconds. Plus 10 seconds, which flufl uses internally to defend against time desync.
There was a problem hiding this comment.
That is not acceptable, I can see it taking that long for the updater on bad network. Just set the longest time by default in Lock and don't configure it unnecessarily each time you use Lock. It is the way our old locks worked, it should stay that way.
|
Reverted to |
Return to zc.lockfile lock in Python 2, NFS is not supported there anyway since sqlite3 doesn't support URIs.
| tmp_dir (str): a directory to store claim files. | ||
| """ | ||
|
|
||
| def __init__(self, lockfile, lifetime=None, tmp_dir=None): |
There was a problem hiding this comment.
Thanks for setting a long default lifetime. Don't see this one used anywhere now
| def __init__(self, lockfile, lifetime=None, tmp_dir=None): | |
| def __init__(self, lockfile, tmp_dir=None): |
There was a problem hiding this comment.
For the record: will remove this myself right after merge to move along faster.
2 participants
This locks employs hardlink trick, which works on NFS and alike unlike
fcntl/open locks.
Closes #1918.