Fix typo in check_can_commit message
#2577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
suggested changes
Oct 5, 2019
dvc/stage.py
Outdated
Contributor
There was a problem hiding this comment.
The style check has failed https://travis-ci.com/iterative/dvc/jobs/242359132#L243 . This line is too long. Have you installed pre-commit hooks as advised in our contribution guide?
Contributor
Author
There was a problem hiding this comment.
This commit was done by the github web IDE (check the branch name "patch-1"), so I did not have access to git hooks. I did check the .pylintrc file and saw that it should be fine with line length (it is 100 there), but I did not open the .flake8 (which is the one used in your hook).
Commit updated & opened #2578 to bring the two lint files' line length setting to parity.
Contributor
|
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.