perf: a small stage validation optimization #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Nov 13, 2019
dvc/utils/__init__.py
Outdated
Contributor
There was a problem hiding this comment.
How does data depend on whether or not builtin_str is a str or not?
Contributor
Author
There was a problem hiding this comment.
The function converts all builtin_str to str (imported from utils.compat) in a nested structure, which is a noop if they are the same, basically in Python 3.
Contributor
Contributor
Author
|
@efiop I haven't benched it, don't want to waste time benching this since it will be dropped with Python 2 anyway in near future. This change makes it's even more obvious that we should drop it. I came across this while optimizing schema validation, the second slowest thing in stage collection. |
Contributor
|
@Suor if this is python2 dependent, then put it into compat or something to make it more obvious. |
Suor
force-pushed
the
convert-to-unicode
branch
from
00fa18a to
3943b0e
Compare
Contributor
Author
|
Moved it to compat. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.