Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exp show: fix column collapse behavior #5753

Merged
merged 1 commit into from Apr 1, 2021

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Apr 1, 2021

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

In exp show we merge adjacent collapsed (minimum width) columns into a single column containing …. Prior to Textualize/rich@2f752af rich assigned collapsed columns a minimum width of 1, after that commit the minimum width became 0.

Will close #5722

@pmrowla pmrowla self-assigned this Apr 1, 2021
@pmrowla pmrowla added bugfix fixes bug ui user interface / interaction labels Apr 1, 2021
@pmrowla pmrowla added this to In progress in DVC 23 March - 06 April 2021 via automation Apr 1, 2021
@pmrowla pmrowla added the skip-changelog Skips changelog label Apr 1, 2021
@skshetry
Copy link
Member

skshetry commented Apr 1, 2021

@pmrowla, would it be possible to send a PR upstream for this feature? The private API could break again.

@pmrowla
Copy link
Contributor Author

pmrowla commented Apr 1, 2021

@pmrowla, would it be possible to send a PR upstream for this feature? The private API could break again.

We could try, but the rich maintainer has stated before that there isn't enough interest to maintain this kind of feature within rich itself: Textualize/rich#98 (comment)

@pmrowla pmrowla merged commit 17e5da7 into iterative:master Apr 1, 2021
DVC 23 March - 06 April 2021 automation moved this from In progress to Done Apr 1, 2021
@pmrowla pmrowla deleted the 5722-rich-10 branch April 1, 2021 07:57
@willmcgugan
Copy link

Open to a PR. Maybe post a discussion on Rich with screenshots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix fixes bug skip-changelog Skips changelog ui user interface / interaction
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

exp show: failing with rich==10.0.0
3 participants