-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Dvclive output subdirs #6628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dvclive output subdirs #6628
Conversation
for more information, see https://pre-commit.ci
|
We still need to make compatible changes on |
Yep. Just wanted to check how this would look on |
|
I believe this is a great idea. Generating summary and HTML is along the |
|
Related: treeverse/dvclive#148 and #6431 (comment). Great idea. I have two questions:
|
β¦/dvc into dvclive-output-subdirs
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@daavoo you requested my review? It LGTM so far, but I guess we need to make corresponding changes in Also, changing how we store HTML and summary will need probably a minor version update on |
|
@daavoo What happened with this PR? Are you planning to keep the |
I was planning on waiting for the HTML layout / further plots development changes to consolidate and get merged before addressing this kind of changes for DVCLive. |
|
Related complaint: https://discord.com/channels/485586884165107732/485596304961962003/915439735256801352. Maybe we should consider reopening this? |
From my understanding, the user would like to be able to put all dvc/dvclive related stuff in some folder (and suggests using There are a few different things that don't seem strictly related to the P.R:
|
π― It's not strictly related. Let me open a separate issue to discuss. |
β I have followed the Contributing to DVC checklist.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
None of the changes are strictly required by DVCLive but I feel like the existing output structure could be revisited after the addition of
imagesupport and the changes tohtmlgeneration (which is now a folder).This P.R. makes
liveoutputs to be ordered in subdirs divided by plot type. Currentlylinearandimages.Summary is now generated under
{live_path}/summary.jsoninstead of{live_path}.json.HTML is now generated under
{live_path}/htmlinstead of{live_path}_dvc_plots.