exp: raise InvalidExpRefError properly #7218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it was just left instantiated, but was not raised.
|
This pull request fixes 1 alert when merging 9395307 into 025e15d - view on LGTM.com fixed alerts:
|
pmrowla
approved these changes
Jan 3, 2022
Contributor
|
@skshetry this needed an additional change to fix CI, the new commit can be squashed into yours but I didn't want to force-push your PR |
|
This pull request fixes 1 alert when merging 0605081 into 175ffae - view on LGTM.com fixed alerts:
|
Collaborator
Author
|
Thanks @pmrowla. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before it was just left instantiated, but was not raised.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏