cli: refactor into a module #7287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
force-pushed
the
cli-refactor
branch
from
1a419c3 to
463c0a3
Compare
By splitting dvc.cli into a module, we'll be able to share cli-related utilities, split parser-related stuffs into smaller parts, improve reusability and improve API for command extensions in the future.
skshetry
force-pushed
the
cli-refactor
branch
from
42217c6 to
1921481
Compare
skshetry
commented
Jan 19, 2022
| # so won't be reused by any other subsequent run anyway. | ||
| clean_repos() | ||
| # TODO: remove in 3.0, kept for backward compatibility | ||
| from .cli import main # noqa: F401, pylint: disable=unused-import |
Collaborator
Author
There was a problem hiding this comment.
Keeping for backward compatibility
Contributor
There was a problem hiding this comment.
@skshetry Could you elaborate, please? We never promised this as an API, so looks like we can get rid of it right away.
Collaborator
Author
There was a problem hiding this comment.
yeah, but I have been suggesting it to the users in Discord as a way to use dvc as a Python API in a stable manner. Could remove though.
Contributor
|
@skshetry Should |
Collaborator
Author
I don't think so. I have a few minor refactors after this:
|
efiop
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By splitting dvc.cli into a module, we'll be able to share cli-related
utilities, split parser-related stuffs into smaller parts, improve
reusability and improve API for command extensions in the future.
This PR moves main entrypoint from
dvc.main.maintodvc.cli.main, but the old one is still kept for backward compatibility, but that should be considered deprecated after this PR is merged and set for removal in 3.0.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏