-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc: add dry option and log num removed objs #9952
Conversation
assert set(odb.oids_exist([*good_cache, *bad_cache])) == good_cache | ||
assert set(odb.all()) == good_cache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assertion was passing even before running gc. It wasn't actually retrieving oids from bad_cache
because it was checking if they exist in the fs, and here they only exist in the odb.
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
Oh my goodness, thank you for this! 🙏 |
Requires iterative/dvc-data#441 (and need to add a version bump here).Closes #9330
Adds
gc --dry
option and reports the number of files removed for each cache.Before this PR (a file is removed here but it look like nothing happened):
After this PR: