Skip to content

More dependency updates #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 4, 2022
Merged

More dependency updates #1969

merged 7 commits into from
Jul 4, 2022

Conversation

@mattseddon
Copy link
Contributor

@mattseddon mattseddon commented Jul 4, 2022 •
edited
Loading

Clearing down some more dependency updates from #1938

@mattseddon mattseddon self-assigned this Jul 4, 2022
@mattseddon mattseddon force-pushed the more-deps-updates branch from 36c19ea to efb3dba Compare July 4, 2022 00:33
mattseddon
mattseddon commented Jul 4, 2022
View reviewed changes
extension/package.json
"engines": {
"vscode": "^1.64.0",
"node": ">=10.2.0"
"node": ">=16.13.0"
Copy link
Contributor Author

@mattseddon mattseddon Jul 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current version of node that VS Code is on

mattseddon
mattseddon commented Jul 4, 2022
View reviewed changes
@mattseddon mattseddon force-pushed the more-deps-updates branch from 8c08d09 to a84b289 Compare July 4, 2022 00:59
@mattseddon mattseddon marked this pull request as ready for review July 4, 2022 01:28
@wolmir
Copy link
Contributor

wolmir commented Jul 4, 2022

I'm still getting this warning on Storybook console:

vendors-node_modules_storybook_addon-actions_manager_js-node_modules_storybook_addon-backgrou-d1ed3d.manager.bundle.js:65418 Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

@qlty-cloud-legacy
Copy link

qlty-cloud-legacy bot commented Jul 4, 2022

Code Climate has analyzed commit 93b6b1b and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (85% is the threshold).

This pull request will bring the total coverage in the repository to 96.5%.

View more on Code Climate.

@mattseddon mattseddon mentioned this pull request Jul 4, 2022
Merged
1 task
@mattseddon mattseddon merged commit b91a0e9 into main Jul 4, 2022
@mattseddon mattseddon deleted the more-deps-updates branch July 4, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rogermparent rogermparent Awaiting requested review from rogermparent

@sroy3 sroy3 Awaiting requested review from sroy3

1 more reviewer

@wolmir wolmir wolmir approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattseddon mattseddon

Labels

🏠 housekeeping

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mattseddon @wolmir