-
Notifications
You must be signed in to change notification settings - Fork 28
Add e2e tests (wdio-vscode-service) #1993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code Climate has analyzed commit 4d637c7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting stuff! Some comments/questions
- It seems this test cannot use the Python extension, so it can't test our integration with it nor can it run in environments that depend on using virtual environments through python (and maybe at all).
I see this doesn't run on CI yet, does it work? I'd imagine so since the integration tests that spawn a VS Code instance work on CI, but anything could happen.just noticed this was mentioned in the OP
| "package": "vsce package --yarn -o ./dvc.vsix", | ||
| "test-vscode-build": "tsc -p .", | ||
| "test-vscode-run": "node ./dist/test/runTest.js", | ||
| "test-e2e": "wdio run ./src/test/e2e/wdio.conf.ts", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mention test:e2e in the OP, but it's test-e2e here. Also, do we want to add an alias to this script in the workspace root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was really confused by this. The problem is that I was working on this late last night and didn't push my final commit up. What you asked for is here. Sorry.
…into end-to-end
I'll start with |
|
Code Climate has analyzed commit f98d17a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.6% (0.0% change). View more on Code Climate. |
@rogermparent I've looked into the service source code and it is not currently possible to start the service without passing |
|
🎉 |
This PR implements end-to-end tests for the repository. It does not wire the new tests up with the CI (that will be the next PR).
I have used the wdio-vscode-service to do this and used example code from vscode-marquee to make the tests worthwhile.
yarn test:e2e:yarn setup:venv)The end-to-end test suite performs the following actions:
There are no mock/stubs in place so we are relying on the CLI to provide the correct data.
Demo (video broken into 2 parts because it was too big)
e2e.experiments.mov
e2e.plots.mov