Extract set active editor context from experiments #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
move-set-active-editor-context
branch
2 times, most recently
from
df80e0d to
52d7c41
Compare
This was referenced Jul 15, 2022
mattseddon
requested review from
julieg18,
rogermparent,
sroy3 and
wolmir
as code owners
rogermparent
approved these changes
Jul 18, 2022
sroy3
approved these changes
Jul 18, 2022
extension/src/experiments/context.ts
Outdated
| setActiveEditorContext(true) | ||
| return | ||
| } | ||
| setActiveEditorContext(false) |
Contributor
There was a problem hiding this comment.
Could we just do something like setActiveEditorContext(getParamsFiles().has(path))? Or maybe set getParamsFiles().has(path) in a const if it needs to be more readable
wolmir
approved these changes
Jul 18, 2022
mattseddon
force-pushed
the
remove-plot-message-sending
branch
from
20f4fe5 to
01aafeb
Compare
mattseddon
force-pushed
the
move-set-active-editor-context
branch
from
52d7c41 to
888756a
Compare
|
Code Climate has analyzed commit 0d9d8fc and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
julieg18
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3/3
main<- #2030 <- #2033 <-thisThis PR extracts more logic out of the
Experimentsclass.