Move divider to top of group in experiments table context menu #2083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattseddon
force-pushed
the
fix-context-menu-divider-placement
branch
from
e3d4a25 to
6d8ae27
Compare
mattseddon
commented
Jul 22, 2022
| } | ||
| WithContextMenu.play = async ({ canvasElement }) => { | ||
| const experiment = await within(canvasElement).findByText('[exp-e7a67]') | ||
| userEvent.click(experiment, { |
Contributor
Author
There was a problem hiding this comment.
The context menu appears to the left of the element clicked on. I spent about 30 minutes looking into a fix. I don't think there is much value in spending any more time looking.
mattseddon
requested review from
julieg18,
rogermparent,
sroy3 and
wolmir
as code owners
julieg18
approved these changes
Jul 22, 2022
sroy3
approved these changes
Jul 22, 2022
mattseddon
commented
Jul 22, 2022
| MessageFromWebviewType.VARY_EXPERIMENT_PARAMS_AND_RUN, | ||
| !isNotCheckpoint, | ||
| !hideVaryAndRun | ||
| !isNotCheckpoint |
Contributor
Author
There was a problem hiding this comment.
This needs a divider when there are no checkpoints.
Contributor
Author
There was a problem hiding this comment.
This is hard to read.
…tive/vscode-dvc into fix-context-menu-divider-placement
|
Code Climate has analyzed commit 112b940 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When demoing the experiments table yesterday I noticed that one of the context menu dividers was in the wrong place. This PR fixes the issue and adds a context menu story.
Screenshot