Update table styles #2133
Update table styles #2133
Conversation
* add cell hover style * add a bottom line every row * remove even row bg style * keep header bg same as body bg * use the same line style for header item separators * keep row arrow same color as left icons * update workspace row, making it sticky and using default row styles
|
@julieg18 please, put a small demo / video in the description. |
|
Looks like there are some changes on the plots side:
Were these intended changes? |
Accidental! Should be fixed now! |
julieg18
left a comment
julieg18
left a comment
There was a problem hiding this comment.
Made some comments based on the discussion in our demo meeting!
|
Had a call with Maxim and went over some desired changes to the design. Going to convert this into a draft for now! |
|
With column styles taken off and styles updated (based off the latest Figma), this pr is ready for another review! |
|
This is default Light High Contrast theme. I don't think we should spend too much time on one specific theme, but I believe high contrast themes should stay high contrast for accessibility |
True! Updated the background color to a variable that is viewable on all themes! Though It does end up being the same (or similar) color as the table on the light themes:
|
| $watermark-color: var(--vscode-descriptionForeground); | ||
|
|
||
| $border-color: var(--vscode-dropdown-border); | ||
| $border-color: var(--checkbox-border); |
There was a problem hiding this comment.
[Q] Any ideas why some of these aren't prefixed with vscode?
There was a problem hiding this comment.
Just realized this actually 😄, I'll update this variable with the vscode prefixed version in the follow-up.
| .runningExperiment.oddRow > .experimentCell & { | ||
| border-left: 1.5px solid $row-bg-alt-color; | ||
| border-bottom: 1.5px solid $row-bg-alt-color; | ||
| } |
There was a problem hiding this comment.
[I] Couple of cases to follow up on:
- Middle of an unselected experiment's circle whilst the row is highlighted
- Middle of a running experiment's spinner whilst highlighted
mattseddon
left a comment
mattseddon
left a comment
There was a problem hiding this comment.
Happy to merge this now, would be good to get the follow-up items addressed before we ship this.
|
Code Climate has analyzed commit d0fd736 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.7% (85% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
5 participants
Screen.Recording.2022-08-15.at.9.54.16.AM.mov
Part of #2070, Fixes #2032